Skip to content

btrfs-progs: better space_cache=v2 support

Omar Sandoval linux-btrfs 2 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 1 replyApplied
  2. v16 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Change unsigned -> unsigned int argument to btrfs_check_fs_compatability() in patch 3
- Remove BUG_ON() in btrfs_del_root() in patch 4
- Return error from btrfs_free_tree_block() in patch 4
- Handle errors from btrfs_free_tree_block() and clean_tree_block() in patch 4
- Add Qu Wenruo's Reviewed-by to patches 3, 4, and 5

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6btrfs-progs: add the FREE_SPACE_TREE_VALID compat_ro bit definitionctree.h+13 -00 replies
2/6btrfs-progs: format FREE_SPACE_TREE{,_VALID} nicely in dump-supercmds-inspect-dump-super.c+24 -00 replies
3/6btrfs-progs: add OPEN_CTREE_INVALIDATE_FST flagchunk-recover.c disk-io.c disk-io.h+28 -120 replies
4/6btrfs-progs: add btrfs_clear_free_space_tree() from the kernelctree.h extent-tree.c free-space-tree.c +2 more+134 -00 replies
5/6btrfs-progs: implement btrfs check --clear-space-cache v2Documentation/btrfs-check.asciidoc cmds-check.c+34 -140 replies
6/6btrfs-progs: document space_cache=v2 more thoroughlyDocumentation/btrfs-man5.asciidoc+25 -180 replies

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchQu Wenruo
1/6
2/6
3/6R-b
4/6R-b
5/6R-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] btrfs-progs: better space_cache=v2 support

From: Omar Sandoval <[email protected]>

Hi,

Cover letter from v1:

This series implements some support for space_cache=v2 in btrfs-progs. In particular, this adds support for btrfs check --clear-space-cache v2, proper printing of the free space tree flags for btrfs inspect-internal dump-super, and better documentation.

We'd previously talked about always making btrfs-progs always invalidate the free space tree when doing write operations, but I decided that this should be an action explicitly requested by the user. It'd also be unsafe if using a kernel without the free space tree valid bit support, which is why I didn't implement a btrfs check --invalidate-free-space-cache option. Doing the full clear is always safe.

Still missing is full read-write support, but this should hopefully cover most btrfs-progs usage.

Changes since v1:

- Change unsigned -> unsigned int argument to btrfs_check_fs_compatability() in patch 3
- Remove BUG_ON() in btrfs_del_root() in patch 4
- Return error from btrfs_free_tree_block() in patch 4
- Handle errors from btrfs_free_tree_block() and clean_tree_block() in patch 4
- Add Qu Wenruo's Reviewed-by to patches 3, 4, and 5

Thanks!

Omar Sandoval (6):
btrfs-progs: add the FREE_SPACE_TREE_VALID compat_ro bit definition
btrfs-progs: format FREE_SPACE_TREE{,_VALID} nicely in dump-super
btrfs-progs: add OPEN_CTREE_INVALIDATE_FST flag
btrfs-progs: add btrfs_clear_free_space_tree() from the kernel
btrfs-progs: implement btrfs check --clear-space-cache v2
btrfs-progs: document space_cache=v2 more thoroughly

 Documentation/btrfs-check.asciidoc | 14 +++---
 Documentation/btrfs-man5.asciidoc  | 43 ++++++++++--------
 chunk-recover.c                    |  2 +-
 cmds-check.c                       | 34 ++++++++++----
 cmds-inspect-dump-super.c          | 24 ++++++++++
 ctree.h                            | 19 ++++++++
 disk-io.c                          | 29 +++++++-----
 disk-io.h                          |  9 +++-
 extent-tree.c                      | 11 +++++
 free-space-tree.c                  | 91 ++++++++++++++++++++++++++++++++++++++
 free-space-tree.h                  |  1 +
 root-tree.c                        | 25 +++++++++++
 12 files changed, 258 insertions(+), 44 deletions(-)
Signature · 1 line
2.10.2