Skip to content

Fixes for Vybrid SPI DMA implementation

Sanchayan Maity linux-arm-kernel linux-spi lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 2 repliesIn review
  2. v24 patches 10 repliesSuperseded
  3. v14 patches 7 repliesSuperseded

Changes in v3 from the cover letter

1. Drop the patch "Fix SPI transfer issue when using multiple SPI_IOC_MESSAGE" since it's now applied and rebase the whole patchset
2. Second patch in this series "Fix continuous selection format" now fixes the issue using an existing function and handling it similar to existing EOQ mode and also cleaning up nicely the transmit code path.
3. Third patch now just fixes the incorrect freeing of DMA allocated buffers and drops the minor clean up patch from earlier series completely due to the clean up from 2 above.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3spi: spi-fsl-dspi: Fix incorrect DMA setupdrivers/spi/spi-fsl-dspi.c+18 -170 replies
2/3spi: spi-fsl-dspi: Fix continuous selection formatdrivers/spi/spi-fsl-dspi.c+6 -141 reply
3/3spi: spi-fsl-dspi: Fix incorrect freeing of DMA allocated buffersdrivers/spi/spi-fsl-dspi.c+4 -21 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchStefan Agner
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] Fixes for Vybrid SPI DMA implementation

Hello,

This v3 set of patches have fixes for Vybrid SPI DMA implementation and is rebased on top of latest topic/fsl-dspi.

http://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/log/?h=topic/fsl-dspi

The patches have been tested on a Toradex Colibri Vybrid VF61 module and now incoporate feedback from Stefan on version 2 of patchset.

Changes since v2:
1. Drop the patch "Fix SPI transfer issue when using multiple SPI_IOC_MESSAGE" since it's now applied and rebase the whole patchset
2. Second patch in this series "Fix continuous selection format" now fixes the issue using an existing function and handling it similar to existing EOQ mode and also cleaning up nicely the transmit code path.
3. Third patch now just fixes the incorrect freeing of DMA allocated buffers and drops the minor clean up patch from earlier series completely due to the clean up from 2 above.

Changes since v1:
1. Place the continuous selection format patch second in order and remove code duplication
2. Improve the use of curr_xfer_len and instead of converting from bytes to DMA transfers in every use, do it at a single place. Accordingly change it's use at other places
3. Code cleanup patch has less to clean with change above

v2:
https://www.spinics.net/lists/arm-kernel/msg543941.html

v1:
http://www.mail-archive.com/linux-kernel at vger.kernel.org/msg1274632.html

Thanks & Regards,
Sanchayan.

Sanchayan Maity (3):
spi: spi-fsl-dspi: Fix incorrect DMA setup
spi: spi-fsl-dspi: Fix continuous selection format
spi: spi-fsl-dspi: Fix incorrect freeing of DMA allocated buffers

 drivers/spi/spi-fsl-dspi.c | 59 +++++++++++++++++++++-------------------------
 1 file changed, 27 insertions(+), 32 deletions(-)
Signature · 1 line
2.10.2