Skip to content

Openrisc gdb patches after yao's comments

Stafford Horne openrisc 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5gdb: or1k: Updates suggested by yao in gdb reviewgdb/configure.tgt gdb/or1k-tdep.c gdb/or1k-tdep.h+881 -18110 replies
2/5gdb: or1k: Remove pseudo registersgdb/or1k-tdep.c+0 -290 replies
3/5or1k: gdb: Simplify handling of tdescgdb/or1k-tdep.c gdb/target-descriptions.c gdb/target-descriptions.h+39 -2690 replies
4/5or1k: gdb: Remove spr commandsgdb/or1k-tdep.c gdb/or1k-tdep.h+0 -10910 replies
5/5gdb: or1k: Just have one number of registersgdb/or1k-tdep.c gdb/or1k-tdep.h+6 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [OpenRISC] [PATCH 0/5] Openrisc gdb patches after yao's comments

Hi All,

I wanted to circulate these patches on the openrisc list first. These are in response to Yao's gdb patch review.

- The first patch is baiscally format and comment updates as per gnu style.
- The second removes the unimplemented pseudo register functions
- Next is the BIG one it removes the handling of target-description parsing and intercepting. But this is as per the recommended way. May what is questionable is how I hard code the reggroups.
- Next removes the special spr commands. I think or1ksim would need to be updated to work with the target-descriptor xml.
- Last is just a cleanup.

The plan would be to squash all of these into the previous patch set I sent.

Test results look ok. Also I tested against openocd and I can reed sprs with commands like info reg upr as expected.

                === gdb Summary ===
# of expected passes            19241
# of unexpected failures        406
# of expected failures          29
# of known failures             57
# of unresolved testcases       2
# of untested testcases         190
# of unsupported tests          264
/home/shorne/work/openrisc/build-gdb/gdb/gdb version  7.12.50.20161122-git 

-Stafford

Stafford Horne (5):
gdb: or1k: Updates suggested by yao in gdb review
gdb: or1k: Remove pseudo registers
or1k: gdb: Simplify handling of tdesc
or1k: gdb: Remove spr commands
gdb: or1k: Just have one number of registers

 gdb/configure.tgt         |   14 -
 gdb/or1k-tdep.c           | 2931 +++++++++------------------------------------
 gdb/or1k-tdep.h           |  389 +-----
 gdb/target-descriptions.c |   34 -
 gdb/target-descriptions.h |   12 -
 5 files changed, 549 insertions(+), 2831 deletions(-)
Signature · 1 line
2.7.4