Skip to content

Couple of BPF fixes

Daniel Borkmann netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyIn review
  2. v12 patches 1 replySuperseded

Changes in v2 from the cover letter

- Patch 1 as is.
- Fixed kbuild bot issue by letting charging helpers stay in the syscall.c, since there locked_vm is valid and only export the ones needed by bpf_prog_realloc(). Add empty stubs in case the bpf syscall is not enabled.
- Added patch 3 that addresses one more issue in map val marking.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3bpf: dynamically allocate digest scratch bufferinclude/linux/bpf.h include/linux/filter.h kernel/bpf/core.c +2 more+33 -180 replies
2/3bpf: fix overflow in prog accountinginclude/linux/bpf.h kernel/bpf/core.c kernel/bpf/syscall.c+52 -110 replies
3/3bpf: fix mark_reg_unknown_value for spilled regs on map value markingkernel/bpf/verifier.c+8 -30 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchAlexei Starovoitov
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net v2 0/3] Couple of BPF fixes

This set contains three BPF fixes for net, one that addresses the complaint from Geert wrt static allocations, and the other is a fix wrt mem accounting that I found recently during testing and there's still one more fix on the map value marking.

Thanks!

v1 -> v2:
- Patch 1 as is.
- Fixed kbuild bot issue by letting charging helpers stay in the syscall.c, since there locked_vm is valid and only export the ones needed by bpf_prog_realloc(). Add empty stubs in case the bpf syscall is not enabled.
- Added patch 3 that addresses one more issue in map val marking.

Daniel Borkmann (3):
bpf: dynamically allocate digest scratch buffer
bpf: fix overflow in prog accounting
bpf: fix mark_reg_unknown_value for spilled regs on map value marking

 include/linux/bpf.h    | 13 ++++++++++++-
 include/linux/filter.h | 14 +++++++++++---
 kernel/bpf/core.c      | 43 +++++++++++++++++++++++++++++--------------
 kernel/bpf/syscall.c   | 38 +++++++++++++++++++++++++++++---------
 kernel/bpf/verifier.c  | 17 ++++++++++++-----
 5 files changed, 93 insertions(+), 32 deletions(-)
Signature · 1 line
1.9.3