Skip to content

ncr5380: Miscellaneous minor patches

Finn Thain linux-scsi lkml 1 version Applied

Status from this message: Applied to 4.11/scsi-queue.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 16 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/6ncr5380: Shorten host info string by removing unused option macrosdrivers/scsi/NCR5380.c drivers/scsi/NCR5380.h+10 -490 replies
2/6ncr5380: Clean up dead code and redundant macro usagedrivers/scsi/NCR5380.h drivers/scsi/atari_scsi.c drivers/scsi/sun3_scsi.c+0 -410 replies
3/6ncr5380: Reduce #include filesdrivers/scsi/g_NCR5380.c drivers/scsi/g_NCR5380.h drivers/scsi/sun3_scsi.c +1 more+122 -1610 replies
4/6ncr5380: Resolve various static checker warningsdrivers/scsi/NCR5380.c drivers/scsi/atari_scsi.c drivers/scsi/mac_scsi.c+9 -60 replies
5/6ncr5380: Improve target selection robustnessdrivers/scsi/NCR5380.c+9 -10 replies
6/6atari_scsi: Reset DMA during bus reset only under ST-DMA lockdrivers/scsi/atari_scsi.c+2 -10 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchOndrej ZaryMichael Schmitz
SeriesT-b T-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] ncr5380: Miscellaneous minor patches

This series removes some unused code and related comments, addresses the warnings generated by 'make W=1' and 'make C=1' and fixes a theoretical bug in the bus reset method in atari_scsi.

There's also a patch to add a missing error check during target selection. The only target I tested was a QUANTUM DAYTONA514S disk as that's all I have access to right now. Some testing with other targets would be prudent.

Michael, Ondrej, can I get you to review/test please?

Finn Thain (6):
ncr5380: Shorten host info string by removing unused option macros
ncr5380: Clean up dead code and redundant macro usage
ncr5380: Reduce #include files
ncr5380: Resolve various static checker warnings
ncr5380: Improve target selection robustness
atari_scsi: Reset DMA during bus reset only under ST-DMA lock

 drivers/scsi/NCR5380.c    |  64 ++++++++++-------------------
 drivers/scsi/NCR5380.h    |  17 +-------
 drivers/scsi/atari_scsi.c |  36 ++--------------
 drivers/scsi/g_NCR5380.c  |  45 +++++++++++++++++++-
 drivers/scsi/g_NCR5380.h  |  56 -------------------------
 drivers/scsi/mac_scsi.c   |   8 ++--
 drivers/scsi/sun3_scsi.c  |  83 +++++++++++++++++++++++++++++++++++--
 drivers/scsi/sun3_scsi.h  | 102 ----------------------------------------------
 8 files changed, 152 insertions(+), 259 deletions(-)
 delete mode 100644 drivers/scsi/g_NCR5380.h
 delete mode 100644 drivers/scsi/sun3_scsi.h
Signature · 1 line
2.10.2