RFC net: improve support for SCTP checksums
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 RFC Latest7 patches 5 repliesIn review
- v3 RFC7 patches 4 repliesSuperseded
- v2 RFC4 patches 8 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 RFC | 5 patches | 8 replies | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | skbuff: add stub to help computing crc32c on SCTP packetsinclude/ net/ net/ | +33 | 0 replies | |
| 2/7 | net: introduce skb_crc32c_csum_helpinclude/ include/ net/ | +43 | 1 reply | |
| 3/7 | sk_buff: remove support for csum_bad in sk_buffdrivers/ include/ include/ +4 more | +9 | 1 reply | |
| 4/7 | net: use skb->csum_not_inet to identify packets needing crc32cinclude/ net/ net/ +2 more | +13 | 1 reply | |
| 5/7 | net: more accurate checksumming in validate_xmit_skb()Documentation/ include/ include/ +1 more | +27 | 0 replies | |
| 6/7 | openvswitch: more accurate checksumming in queue_userspace_packet()net/ | +1 | 0 replies | |
| 7/7 | sk_buff.h: improve description of CHECKSUM_{COMPLETE,UNNECESSARY}include/ | +5 | 1 reply |
Reviews trailers per patch
4 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Marcelo Ricardo Leitner | Tom Herbert |
|---|---|---|
| 1/7 | R-b | |
| 2/7 | ||
| 3/7 | A-b | |
| 4/7 | A-b | |
| 5/7 | ||
| 6/7 | ||
| 7/7 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH RFC net-next v4 0/7] net: improve support for SCTP checksums
hello Tom,
Quoted 2 lines · Tom Herbert
maybe just call it
csum_not_ipthen. Then just do "if (unlikely(skb->csum_not_ip)) ..."
Ok, done. V4 uses this bit for SCTP only and leaves unmodified behavior when offloaded FCoE frames are processed. Further work is still possible to extend this fix for FCoE, if needed, either by using additional sk_buff bits, or using skb->csum_not_ip and use other data (e.g. skb->csum_offset) to distinguish SCTP from FCoE.
Quoted 4 lines
the only case where this new bit is relevant is when
CHECKSUM_PARTIALfor a CRC is being done. When it's set for offloading sctp crc it must be set. When CRC is resolved, in the helper for instance, it must be cleared.
in V4 the bit is set when SCTP packets with offloaded checksum are generated; the bit is cleared when CRC32c is resolved for such packets (i.e. skb->ip_summed transitions from CHECKSUM_PARTIAL to CHECKSUM_NONE).
Any feedbacks are appreciated!
thank you in advance,
--
davide
Davide Caratti (7):
skbuff: add stub to help computing crc32c on SCTP packets
net: introduce skb_crc32c_csum_help
sk_buff: remove support for csum_bad in sk_buff
net: use skb->csum_not_inet to identify packets needing crc32c
net: more accurate checksumming in validate_xmit_skb()
openvswitch: more accurate checksumming in queue_userspace_packet() sk_buff.h: improve description of CHECKSUM_{COMPLETE,UNNECESSARY}
Documentation/networking/checksum-offloads.txt | 11 +++-- drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 2 +- include/linux/netdevice.h | 8 +-- include/linux/skbuff.h | 58 +++++++++------------- net/bridge/netfilter/nft_reject_bridge.c | 5 +- net/core/dev.c | 63 +++++++++++++++++++++--- net/core/skbuff.c | 24 +++++++++ net/ipv4/netfilter/nf_reject_ipv4.c | 2 +- net/ipv6/netfilter/nf_reject_ipv6.c | 3 -- net/openvswitch/datapath.c | 2 +- net/sched/act_csum.c | 1 + net/sctp/offload.c | 8 +++ net/sctp/output.c | 1 + 13 files changed, 128 insertions(+), 60 deletions(-)
Signature · 1 line
2.7.4