Skip to content

iscsi: Add blockdev-add support

Jeff Cody qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest7 patches 13 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7iscsi: Split URL into individual optionsblock/iscsi.c+136 -531 reply
2/7iscsi: Handle -iscsi user/password in bdrv_parse_filename()block/iscsi.c+44 -344 replies
3/7iscsi: Add initiator-name optionblock/iscsi.c+15 -171 reply
4/7iscsi: Add header-digest optionblock/iscsi.c+15 -241 reply
5/7iscsi: Add timeout optionblock/iscsi.c+11 -261 reply
6/7iscsi: Add blockdev-add supportblock/iscsi.c qapi/block-core.json+78 -103 replies
7/7QAPI: Fix blockdev-add example documentationqapi/block-core.json+9 -91 reply

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by.

PatchDaniel P. BerrangeFam Zheng
1/7R-b
2/7R-b
3/7R-b R-b
4/7R-b R-b
5/7R-b R-b
6/7R-b R-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/7] iscsi: Add blockdev-add support

This adds blockdev-add support to the iscsi block driver.

Picked this series up from Kevin. I've tested it on my local iscsi setup.

There are only a few minor changes:

* In patch 2, fixed the segfault pointed out by Daniel
* In patch 6, placed the ':' after the command header as now required
* New patch 7, to fix some out of date documentation in the qapi schema

Jeff Cody (1):
QAPI: Fix blockdev-add example documentation

Kevin Wolf (6):
iscsi: Split URL into individual options
iscsi: Handle -iscsi user/password in bdrv_parse_filename()
iscsi: Add initiator-name option
iscsi: Add header-digest option
iscsi: Add timeout option
iscsi: Add blockdev-add support

 block/iscsi.c        | 349 +++++++++++++++++++++++++++++++--------------------
 qapi/block-core.json |  92 +++++++++++---
 2 files changed, 288 insertions(+), 153 deletions(-)
Signature · 1 line
2.9.3