Skip to content

Btrfs: disable xattr operations on subvolume directories

Omar Sandoval linux-btrfs stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest3 patches 4 repliesIn review

Changes in v2 from the cover letter

- Added patch 1 to remove an obsolete place where we use btrfs_dir_ro_inode_operations since the fix in patch 2 concerns btrfs_dir_ro_inode_operations.
- Added patch 3. It's mostly a cleanup, but I can't convince myself that there aren't any in-kernel callers that will change ACLs directly. Let's get this in just to be safe.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Btrfs: remove old tree_root case in btrfs_read_locked_inode()fs/btrfs/inode.c+1 -41 reply
2/3Btrfs: disable xattr operations on subvolume directoriesfs/btrfs/inode.c+1 -01 reply
3/3Btrfs: remove ->{get,set}_acl() from btrfs_dir_ro_inode_operationsfs/btrfs/inode.c+0 -21 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchChris MurphyDavid Sterba
1/3R-b
2/3T-b R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Btrfs: disable xattr operations on subvolume directories

From: Omar Sandoval <[email protected]>

This series is based on v4.10-rc4. It should probably go in for v4.10 and to stable for v4.9.x.

Changes from v1:

- Added patch 1 to remove an obsolete place where we use btrfs_dir_ro_inode_operations since the fix in patch 2 concerns btrfs_dir_ro_inode_operations.
- Added patch 3. It's mostly a cleanup, but I can't convince myself that there aren't any in-kernel callers that will change ACLs directly. Let's get this in just to be safe.

There are some more followup cleanups to do here, but let's get this fix in first.

Omar Sandoval (3):
Btrfs: remove old tree_root case in btrfs_read_locked_inode()
Btrfs: disable xattr operations on subvolume directories
Btrfs: remove ->{get,set}_acl() from btrfs_dir_ro_inode_operations

 fs/btrfs/inode.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
Signature · 1 line
2.11.0