Skip to content

drm/i915/dp: link rate and lane count refactoring

Jani Nikula intel-gfx 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest14 patches 17 repliesIn review
  2. v213 patches 5 repliesSuperseded
  3. v113 patches 16 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14drm/i915/dp: use known correct array size in rate_to_indexdrivers/gpu/drm/i915/intel_dp.c+6 -51 reply
2/14drm/i915/dp: return errors from rate_to_index()drivers/gpu/drm/i915/intel_dp.c+9 -43 replies
3/14drm/i915/dp: rename rate_to_index() to intel_dp_rate_index() and reusedrivers/gpu/drm/i915/intel_dp.c+15 -191 reply
4/14drm/i915/dp: cache source rates at initdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h+24 -141 reply
5/14drm/i915/dp: generate and cache sink rate array for all DP, not just eDP 1.4drivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_dp_link_training.c drivers/gpu/drm/i915/intel_drv.h+61 -282 replies
6/14drm/i915/dp: use the sink rates array for max sink ratesdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h+8 -220 replies
7/14drm/i915/dp: cache common rates with sink ratesdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h+45 -331 reply
8/14drm/i915/dp: do not limit rate seek when not neededdrivers/gpu/drm/i915/intel_dp.c+12 -193 replies
9/14drm/i915/dp: don't call the link parameters sink parametersdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h+16 -171 reply
10/14drm/i915/dp: add functions for max common link rate and lane countdrivers/gpu/drm/i915/intel_dp.c+17 -121 reply
11/14drm/i915/mst: use max link not sink lane countdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_dp_mst.c drivers/gpu/drm/i915/intel_drv.h+4 -31 reply
12/14drm/i915/dp: localize link rate index variable moredrivers/gpu/drm/i915/intel_dp.c+7 -63 replies
13/14drm/i915/dp: use readb and writeb calls for single byte DPCD accessdrivers/gpu/drm/i915/intel_dp.c+17 -201 reply
14/14drm/i915/dp: read sink count to a temporary variable firstdrivers/gpu/drm/i915/intel_dp.c+4 -30 replies

Reviews trailers per patch

11 of 14 patches have a Reviewed-by or Acked-by.

PatchManasi Navare
1/14R-b
2/14R-b
3/14R-b
4/14R-b
5/14R-b
6/14
7/14R-b
8/14R-b
9/14R-b
10/14R-b
11/14
12/14R-b
13/14R-b
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/14] drm/i915/dp: link rate and lane count refactoring

v3 of [1], rebased and review addressed.

This might still conflict with some of Manasi's pending work, but I think for the most parts we could start pushing these. The scales are tipping, it'll be easier to rebase Manasi's stuff than this. Indeed some of it may be easier to understand after the changes here.

BR,
Jani.

[1] http://mid.mail-archive.com/[email protected]

Jani Nikula (14):
drm/i915/dp: use known correct array size in rate_to_index drm/i915/dp: return errors from rate_to_index() drm/i915/dp: rename rate_to_index() to intel_dp_rate_index() and reuse drm/i915/dp: cache source rates at init
drm/i915/dp: generate and cache sink rate array for all DP, not just

    eDP 1.4

drm/i915/dp: use the sink rates array for max sink rates drm/i915/dp: cache common rates with sink rates drm/i915/dp: do not limit rate seek when not needed drm/i915/dp: don't call the link parameters sink parameters drm/i915/dp: add functions for max common link rate and lane count drm/i915/mst: use max link not sink lane count drm/i915/dp: localize link rate index variable more drm/i915/dp: use readb and writeb calls for single byte DPCD access drm/i915/dp: read sink count to a temporary variable first

 drivers/gpu/drm/i915/intel_dp.c               | 291 ++++++++++++++------------
 drivers/gpu/drm/i915/intel_dp_link_training.c |   3 +-
 drivers/gpu/drm/i915/intel_dp_mst.c           |   4 +-
 drivers/gpu/drm/i915/intel_drv.h              |  20 +-
 4 files changed, 179 insertions(+), 139 deletions(-)
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx