Skip to content

#10619: refactor wic codebase (start)

Ed Bartosh openembedded-core 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18wic: creator: stop using config managerscripts/lib/wic/creator.py+0 -190 replies
2/18wic: direct_plugin: stop using config managerscripts/lib/wic/imager/direct.py scripts/lib/wic/plugins/imager/direct_plugin.py+20 -120 replies
3/18wic: removed conf.py and empty config file.scripts/lib/wic/conf.py scripts/lib/wic/config/wic.conf+0 -1090 replies
4/18wic: moved content of direct.py to direct_pluginscripts/lib/wic/imager/__init__.py scripts/lib/wic/imager/direct.py scripts/lib/wic/plugins/imager/direct_plugin.py+380 -4180 replies
5/18wic: get rid of __rootfs_dir_to_dict methodscripts/lib/wic/plugins/imager/direct_plugin.py+5 -160 replies
6/18wic: improve naming in direct_plugin classesscripts/lib/wic/plugins/imager/direct_plugin.py+22 -400 replies
7/18wic: pylinted direct_pluginscripts/lib/wic/plugins/imager/direct_plugin.py+7 -150 replies
8/18wic: simplified code of direct_pluginscripts/lib/wic/plugins/imager/direct_plugin.py+2 -220 replies
9/18wic: renamd direct_plugin.py -> direct.pyscripts/lib/wic/plugins/imager/direct.py+0 -00 replies
10/18wic: removed test filescripts/lib/wic/test+0 -10 replies
11/18wic: partition: simlify calling plugin methodsscripts/lib/wic/partition.py scripts/lib/wic/utils/oe/misc.py+25 -510 replies
12/18wci: misc: removed build_name APIscripts/lib/wic/utils/misc.py+0 -390 replies
13/18wic: move 2 APIs to wic.enginescripts/lib/wic/engine.py scripts/lib/wic/ksparser.py scripts/lib/wic/plugins/source/bootimg-efi.py +3 more+37 -620 replies
14/18wic: move oe/misc.py one level upscripts/lib/wic/engine.py scripts/lib/wic/partition.py scripts/lib/wic/plugin.py +12 more+21 -210 replies
15/18wic: removed code from __init__.pyscripts/lib/wic/__init__.py+0 -40 replies
16/18wic: msger.py: remove unused APIsscripts/lib/wic/msger.py+0 -260 replies
17/18wic: code cleanupscripts/lib/wic/__version__.py scripts/lib/wic/engine.py scripts/lib/wic/help.py +12 more+36 -430 replies
18/18wic: remove syslinux.pyscripts/lib/wic/plugins/source/rootfs_pcbios_ext.py scripts/lib/wic/utils/syslinux.py+37 -590 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/18] #10619: refactor wic codebase (start)

Hi,

This patchset consolidates wic APIs in a more maintainable way, removes unused APIs and cleans up wic code.

This is a first series of a refactoring work. The changes in this patchset are relatively simple. They're a preparation for upcoming heavy work on making wic codebase less complex and more maintainable.

The following changes since commit ec3d83f9a90288403b96be25da855fa280aadd8d:

xmlto: Don't hardcode the path to tail (2017-01-31 23:47:33 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ed/wic/refactoring-10619
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wic/refactoring-10619

Ed Bartosh (18):
wic: creator: stop using config manager
wic: direct_plugin: stop using config manager
wic: removed conf.py and empty config file.
wic: moved content of direct.py to direct_plugin
wic: get rid of __rootfs_dir_to_dict method
wic: improve naming in direct_plugin classes
wic: pylinted direct_plugin
wic: simplified code of direct_plugin
wic: renamd direct_plugin.py -> direct.py
wic: removed test file
wic: partition: simlify calling plugin methods
wci: misc: removed build_name API
wic: move 2 APIs to wic.engine
wic: move oe/misc.py one level up
wic: removed code from __init__.py
wic: msger.py: remove unused APIs
wic: code cleanup
wic: remove syslinux.py

 scripts/lib/wic/__init__.py                        |   4 -
 scripts/lib/wic/__version__.py                     |   1 -
 scripts/lib/wic/conf.py                            | 103 --------
 scripts/lib/wic/config/wic.conf                    |   6 -
 scripts/lib/wic/creator.py                         |  19 --
 scripts/lib/wic/engine.py                          |  39 ++-
 scripts/lib/wic/help.py                            |   4 +-
 scripts/lib/wic/imager/__init__.py                 |   0
 scripts/lib/wic/ksparser.py                        |   2 +-
 scripts/lib/wic/msger.py                           |  26 --
 scripts/lib/wic/partition.py                       |  66 ++---
 scripts/lib/wic/plugin.py                          |   5 +-
 scripts/lib/wic/pluginbase.py                      |   1 -
 scripts/lib/wic/{ => plugins}/imager/direct.py     | 139 ++++++-----
 scripts/lib/wic/plugins/imager/direct_plugin.py    | 103 --------
 scripts/lib/wic/plugins/source/bootimg-efi.py      |  20 +-
 .../lib/wic/plugins/source/bootimg-partition.py    |   6 +-
 scripts/lib/wic/plugins/source/bootimg-pcbios.py   |  12 +-
 scripts/lib/wic/plugins/source/fsimage.py          |   2 +-
 .../lib/wic/plugins/source/isoimage-isohybrid.py   |  15 +-
 scripts/lib/wic/plugins/source/rawcopy.py          |   3 +-
 scripts/lib/wic/plugins/source/rootfs.py           |   6 +-
 .../lib/wic/plugins/source/rootfs_pcbios_ext.py    |  46 +++-
 scripts/lib/wic/test                               |   1 -
 scripts/lib/wic/utils/misc.py                      | 274 +++++++++++++++------
 scripts/lib/wic/utils/oe/misc.py                   | 247 -------------------
 scripts/lib/wic/utils/partitionedfs.py             |   7 +-
 scripts/lib/wic/utils/syslinux.py                  |  58 -----
 scripts/wic                                        |   2 +-
 29 files changed, 426 insertions(+), 791 deletions(-)
 delete mode 100644 scripts/lib/wic/__version__.py
 delete mode 100644 scripts/lib/wic/conf.py
 delete mode 100644 scripts/lib/wic/config/wic.conf
 delete mode 100644 scripts/lib/wic/imager/__init__.py
 rename scripts/lib/wic/{ => plugins}/imager/direct.py (80%)
 delete mode 100644 scripts/lib/wic/plugins/imager/direct_plugin.py
 delete mode 100644 scripts/lib/wic/test
 delete mode 100644 scripts/lib/wic/utils/oe/misc.py
 delete mode 100644 scripts/lib/wic/utils/syslinux.py
Signature · 1 line
2.1.4