Skip to content

#10619: refactor wic codebase. Part 3

Ed Bartosh openembedded-core 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13wic: move disk operations to PartitionImage classscripts/lib/wic/plugins/imager/direct.py scripts/lib/wic/plugins/source/bootimg-pcbios.py scripts/lib/wic/plugins/source/isoimage-isohybrid.py +2 more+111 -1960 replies
2/13wic: move PartitionedImage class to direct.pyscripts/lib/wic/plugins/imager/direct.py scripts/lib/wic/utils/partitionedfs.py+276 -3030 replies
3/13wic: remove utils/oe/__init__.pyscripts/lib/wic/utils/oe/__init__.py+0 -220 replies
4/13wic: ksparser: set default disk to 'sda'scripts/lib/wic/ksparser.py+1 -10 replies
5/13wic: direct: remove set_bootimg_dir setterscripts/lib/wic/plugins/imager/direct.py scripts/lib/wic/plugins/source/bootimg-efi.py scripts/lib/wic/plugins/source/bootimg-pcbios.py+2 -110 replies
6/13wic: direct: don't catch ImagerErrorscripts/lib/wic/plugins/imager/direct.py+1 -40 replies
7/13wic: direct: remove useless codescripts/lib/wic/plugins/imager/direct.py+1 -30 replies
8/13wic: direct: add 'realnum' attribute to partitionscripts/lib/wic/plugins/imager/direct.py+20 -260 replies
9/13wic: direct: move UUID generation to PartitionedImagescripts/lib/wic/plugins/imager/direct.py+11 -120 replies
10/13wic: direct: set bootloader.source in the __init__scripts/lib/wic/plugins/imager/direct.py+7 -60 replies
11/13wic: direct: add PartitionedImage.prepare methodscripts/lib/wic/plugins/imager/direct.py+11 -130 replies
12/13wic: direct: move generation of part.realnum to PartitionedImagescripts/lib/wic/plugins/imager/direct.py+13 -130 replies
13/13wic: direct: move creation of PartitionedImage to __init__scripts/lib/wic/plugins/imager/direct.py+4 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/13] #10619: refactor wic codebase. Part 3

Hi,

This patchset introduces PartitionedImage class and moves partition operations to it. This should simplify the API and make it easier to understand and maintain.

The following changes since commit 5ea229d46a6ef4a197564815c51ee4c5d23a00c9:

wic: remove unused argument scripts_path (2017-02-09 16:10:56 +0200)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ed/wic/wip
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wic/wip

Ed Bartosh (13):
wic: move disk operations to PartitionImage class
wic: move PartitionedImage class to direct.py
wic: remove utils/oe/__init__.py
wic: ksparser: set default disk to 'sda'
wic: direct: remove set_bootimg_dir setter
wic: direct: don't catch ImagerError
wic: direct: remove useless code
wic: direct: add 'realnum' attribute to partition
wic: direct: move UUID generation to PartitionedImage
wic: direct: set bootloader.source in the __init__
wic: direct: add PartitionedImage.prepare method
wic: direct: move generation of part.realnum to PartitionedImage
wic: direct: move creation of PartitionedImage to __init__

 scripts/lib/wic/ksparser.py                        |   2 +-
 scripts/lib/wic/plugins/imager/direct.py           | 465 +++++++++++++++------
 scripts/lib/wic/plugins/source/bootimg-efi.py      |   2 +-
 scripts/lib/wic/plugins/source/bootimg-pcbios.py   |   4 +-
 .../lib/wic/plugins/source/isoimage-isohybrid.py   |  10 +-
 .../lib/wic/plugins/source/rootfs_pcbios_ext.py    |   4 +-
 scripts/lib/wic/utils/oe/__init__.py               |  22 -
 scripts/lib/wic/utils/partitionedfs.py             | 345 ---------------
 8 files changed, 349 insertions(+), 505 deletions(-)
 delete mode 100644 scripts/lib/wic/utils/oe/__init__.py
 delete mode 100644 scripts/lib/wic/utils/partitionedfs.py

--
Regards,
Ed