Skip to content

wic refactoring (almost done)

Ed Bartosh openembedded-core 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11wic: setup logging in the main wic modulescripts/wic+44 -330 replies
2/11wic: use wic logger in core modulesscripts/lib/wic/engine.py scripts/lib/wic/help.py scripts/lib/wic/ksparser.py +5 more+104 -770 replies
3/11wic: use wic logger in imager direct pluginscripts/lib/wic/plugins/imager/direct.py+43 -400 replies
4/11wic: use wic logger in wic source pluginsscripts/lib/wic/plugins/source/bootimg-efi.py scripts/lib/wic/plugins/source/bootimg-partition.py scripts/lib/wic/plugins/source/bootimg-pcbios.py +5 more+200 -1350 replies
5/11wic: remove msger modulescripts/lib/wic/engine.py scripts/lib/wic/msger.py+0 -2130 replies
6/11wic: move errors modulescripts/lib/wic/errors.py scripts/lib/wic/plugin.py scripts/lib/wic/plugins/imager/direct.py +3 more+6 -70 replies
7/11wic: raise WicError in main modulescripts/wic+23 -330 replies
8/11wic: raise WicError in core modulesscripts/lib/wic/engine.py scripts/lib/wic/partition.py scripts/lib/wic/utils/misc.py +1 more+36 -430 replies
9/11wic: raise WicError in wic pluginsscripts/lib/wic/plugins/imager/direct.py scripts/lib/wic/plugins/source/bootimg-efi.py scripts/lib/wic/plugins/source/bootimg-partition.py +6 more+75 -1240 replies
10/11wic: raise WicError instead of ImageError and CreatorErrorscripts/lib/wic/plugin.py scripts/lib/wic/plugins/imager/direct.py scripts/lib/wic/plugins/source/bootimg-pcbios.py +1 more+9 -90 replies
11/11wic: move WicError to lib/wic/__init__.pyscripts/lib/wic/__init__.py scripts/lib/wic/engine.py scripts/lib/wic/errors.py +14 more+35 -450 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/11] wic refactoring (almost done)

Hi,

This patchset takes care of logging and error handling:
- remove custom msger module in favor of standard python logging
- raise WicError exception instead of calling sys.exit

This is the one of the last changes for this time.

I'm thinking about refactoring wic plugin system, but haven't decided yet if it makes sense to do right now or not. Other than that I'm happy with the state of the wic codebase for now. There are still many things to improve, but it looks and feels much better now.

The following changes since commit 10d1f08f71a623ca6d45cf0ae1afa2e880591a09:

wic: direct: move creation of PartitionedImage to __init__ (2017-02-10 16:44:03 +0200)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ed/wic/wip
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wic/wip

Ed Bartosh (11):
wic: setup logging in the main wic module
wic: use wic logger in core modules
wic: use wic logger in imager direct plugin
wic: use wic logger in wic source plugins
wic: remove msger module
wic: move errors module
wic: raise WicError in main module
wic: raise WicError in core modules
wic: raise WicError in wic plugins
wic: raise WicError instead of ImageError and CreatorError
wic: move WicError to lib/wic/__init__.py

 scripts/lib/wic/__init__.py                        |  20 ++
 scripts/lib/wic/engine.py                          |  28 ++-
 scripts/lib/wic/help.py                            |   8 +-
 scripts/lib/wic/ksparser.py                        |   7 +-
 scripts/lib/wic/msger.py                           | 209 ---------------------
 scripts/lib/wic/partition.py                       |  68 +++----
 scripts/lib/wic/plugin.py                          |  24 +--
 scripts/lib/wic/pluginbase.py                      |  12 +-
 scripts/lib/wic/plugins/imager/direct.py           |  87 ++++-----
 scripts/lib/wic/plugins/source/bootimg-efi.py      |  52 ++---
 .../lib/wic/plugins/source/bootimg-partition.py    |  25 +--
 scripts/lib/wic/plugins/source/bootimg-pcbios.py   |  41 ++--
 scripts/lib/wic/plugins/source/fsimage.py          |  14 +-
 .../lib/wic/plugins/source/isoimage-isohybrid.py   |  79 ++++----
 scripts/lib/wic/plugins/source/rawcopy.py          |  12 +-
 scripts/lib/wic/plugins/source/rootfs.py           |  21 ++-
 .../lib/wic/plugins/source/rootfs_pcbios_ext.py    |  54 +++---
 scripts/lib/wic/utils/errors.py                    |  29 ---
 scripts/lib/wic/utils/misc.py                      |  34 ++--
 scripts/lib/wic/utils/runner.py                    |  12 +-
 scripts/wic                                        | 104 +++++-----
 21 files changed, 378 insertions(+), 562 deletions(-)
 delete mode 100644 scripts/lib/wic/msger.py
 delete mode 100644 scripts/lib/wic/utils/errors.py

--
Regards,
Ed