Skip to content

Improvements for SM501 display controller emulation

BALATON Zoltan qemu-devel qemu-trivial 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest13 patches 2 repliesIn review
  2. v613 patches 2 repliesSuperseded
  3. v513 patches 2 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v413 patches4 repliesSuperseded
v313 patches16 repliesSuperseded
v214 patches38 repliesApplied
v110 patches25 repliesSuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13sm501: Fixed code style and a few typos in commentshw/display/sm501.c hw/display/sm501_template.h+594 -5900 replies
2/13sm501: Use defined constants instead of literal values where availablehw/display/sm501.c hw/display/sm501_template.h+20 -110 replies
3/13sm501: Add missing arbitration control registerhw/display/sm501.c+8 -00 replies
4/13sm501: QOMifyhw/display/sm501.c hw/sh4/r2d.c include/hw/devices.h+133 -530 replies
5/13sm501: Get rid of base address in draw_hwc_linehw/display/sm501.c hw/display/sm501_template.h+6 -80 replies
6/13sm501: Add emulation of chip connected via PCIhw/display/sm501.c include/hw/pci/pci_ids.h+68 -00 replies
7/13sm501: Fix device endiannesshw/display/sm501.c hw/display/sm501_template.h+10 -170 replies
8/13sm501: Fix hardware cursorhw/display/sm501.c hw/display/sm501_template.h+107 -870 replies
9/13sm501: Misc clean upshw/display/sm501.c hw/display/sm501_template.h+9 -110 replies
10/13sm501: Add support for panel layerhw/display/sm501.c+32 -310 replies
11/13sm501: Add some more missing registershw/display/sm501.c+125 -10 replies
12/13sm501: Add vmstate descriptorhw/display/sm501.c+99 -10 replies
13/13ppc: Add SM501 device in ppc softmmu targets default configsdefault-configs/ppc-softmmu.mak default-configs/ppc64-softmmu.mak default-configs/ppcemb-softmmu.mak+3 -00 replies

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchPeter MaydellAurelien JarnoDavid Gibson
1/13R-b T-b
2/13R-b T-b
3/13R-b T-b
4/13R-b T-b
5/13R-b T-b
6/13R-b T-b
7/13R-b T-b
8/13R-b T-b
9/13R-b T-b
10/13R-b T-b
11/13R-b T-b
12/13R-b T-b
13/13T-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [Qemu-devel] [PATCH v7 00/13] Improvements for SM501 display controller emulation

v7: Define default values for some variables to avoid an (invalid)
warning from gcc 6 or 7 as suggested by Aurelien Jarno.

BALATON Zoltan (13):
sm501: Fixed code style and a few typos in comments
sm501: Use defined constants instead of literal values where available
sm501: Add missing arbitration control register
sm501: QOMify
sm501: Get rid of base address in draw_hwc_line
sm501: Add emulation of chip connected via PCI
sm501: Fix device endianness
sm501: Fix hardware cursor
sm501: Misc clean ups
sm501: Add support for panel layer
sm501: Add some more missing registers
sm501: Add vmstate descriptor
ppc: Add SM501 device in ppc softmmu targets default configs

 default-configs/ppc-softmmu.mak    |    1 +
 default-configs/ppc64-softmmu.mak  |    1 +
 default-configs/ppcemb-softmmu.mak |    1 +
 hw/display/sm501.c                 | 1784 ++++++++++++++++++++++--------------
 hw/display/sm501_template.h        |   90 +-
 hw/sh4/r2d.c                       |   11 +-
 include/hw/devices.h               |    5 -
 include/hw/pci/pci_ids.h           |    3 +
 8 files changed, 1150 insertions(+), 746 deletions(-)
Signature · 1 line
2.7.4

Read the cover letter in its thread