Skip to content

staging: bcm2835-audio: fix multiple checkpatch warnings

Aishwarya Pant outreachy 5 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 2 repliesIn review
  2. v41 of 5 patches 2 repliesSuperseded
  3. v35 patches 1 replySuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches1 replySuperseded
v15 patches2 repliesSuperseded

Changes in v5 from the cover letter

-Fix out of place commit messages

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5staging: bcm2835-audio: remove space after castdrivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c+3 -30 replies
2/5staging: bcm2835-audio: move logical continuation to the same linedrivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c+1 -20 replies
3/5staging: bcm2835-audio: use kernel preferred block commenting styledrivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c+4 -30 replies
4/5staging: bcm2835-audio: remove extra blank linedrivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c+0 -10 replies
5/5staging: bcm2835-audio: replace printk(KERN_ERR...) with dev_err(...)drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c+2 -41 reply

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchJulia Lawall
1/5
2/5
3/5
4/5
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/5] staging: bcm2835-audio: fix multiple checkpatch warnings

Fix multiple code styling warnings issued by checkpatch on file bcm2835-ctl.c in bcm2835-audio driver

Changes in v5:
-Fix out of place commit messages
Changes in v4:
-Refactor commit messages
Changes in v3:
-Merge two if conditions
-Fix subject of patch replace printk(... by dev_err(...
Changes in v2:
-Replace pr_err with dev_err

Aishwarya Pant (5):
*** HERE ***
staging: bcm2835-audio: remove space after cast
staging: bcm2835-audio: move logical continuation to the same line
staging: bcm2835-audio: use kernel preferred block commenting style
staging: bcm2835-audio: remove extra blank line
staging: bcm2835-audio: replace printk(KERN_ERR...) with dev_err(...)

 .../vc04_services/bcm2835-audio/bcm2835-ctl.c      | 23 ++++++++++------------
 1 file changed, 10 insertions(+), 13 deletions(-)
Signature · 1 line
2.7.4