Skip to content

net/tap: support flow API

Pascal Mazon dpdk-dev 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest4 patches 1 replyIn review
  2. v64 patches 2 repliesSuperseded
  3. v54 patches 5 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v44 patches2 repliesSuperseded
v34 patches4 repliesSuperseded
v24 patches2 repliesSuperseded
v14 patches6 repliesSuperseded

Changes in v7 from the cover letter

- provide more details in doc/guides/nics/tap.rst

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net/tap: move private elements to external headerdrivers/net/tap/Makefile drivers/net/tap/rte_eth_tap.c drivers/net/tap/rte_eth_tap.h+78 -340 replies
2/4net/tap: add preliminary support for rte_flowdoc/guides/nics/features/tap.ini drivers/net/tap/Makefile drivers/net/tap/rte_eth_tap.c +3 more+241 -00 replies
3/4net/tap: add netlink back-end for flow APIdrivers/net/tap/Makefile drivers/net/tap/tap_netlink.c drivers/net/tap/tap_netlink.h +2 more+879 -00 replies
4/4net/tap: add basic flow API patterns and actionsdoc/guides/nics/tap.rst drivers/net/tap/Makefile drivers/net/tap/rte_eth_tap.c +3 more+1057 -150 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchOlga ShernKeith Wiles
1/4A-b A-b
2/4A-b A-b
3/4A-b A-b
4/4A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/4] net/tap: support flow API

This series adds support for the flow API in tap PMD.

It enables filtering specific packets incoming on the tap netdevice, to process only desired ones. Under the hood, it uses kernel TC (traffic control), which takes place very early in the stack, and supports most common pattern items and actions defined in the flow API.

v7 changes:
- provide more details in doc/guides/nics/tap.rst

v6 changes:
- fix compilation issue on i686 (wrong cast for rte flow handle)

v5 changes:
- rebase after adrien's patches on Tx poll and Rx signaling
- better spaces for comments in rte_eth_tap.h

v4 changes:
- rebase on top of "net/tap: add additional management ops" series
- fix a few netlink doxygen comments
- rename tap.h -> rte_eth_tap.h
- flush flow rules only when applicable

v3 changes:
- vlan patterns enabled depending on running kernel (4.9+)
- update doc/guides/nics/tap.rst for Flow API support
- rebase on top of "net/tap: add additional management ops" series

v2 changes:
- support compilation on kernels < 4.2 (where flower support appeared)
- set whitespaces in tap.h
- remove unnecessary goto

Pascal Mazon (4):
net/tap: move private elements to external header net/tap: add preliminary support for rte_flow net/tap: add netlink back-end for flow API net/tap: add basic flow API patterns and actions

 doc/guides/nics/features/tap.ini |    1 +
 doc/guides/nics/tap.rst          |   45 ++
 drivers/net/tap/Makefile         |   44 ++
 drivers/net/tap/rte_eth_tap.c    |  101 ++--
 drivers/net/tap/rte_eth_tap.h    |   80 +++
 drivers/net/tap/tap_flow.c       | 1070 ++++++++++++++++++++++++++++++++++++++
 drivers/net/tap/tap_flow.h       |   58 +++
 drivers/net/tap/tap_netlink.c    |  367 +++++++++++++
 drivers/net/tap/tap_netlink.h    |   69 +++
 drivers/net/tap/tap_tcmsgs.c     |  378 ++++++++++++++
 drivers/net/tap/tap_tcmsgs.h     |   63 +++
 11 files changed, 2241 insertions(+), 35 deletions(-)
 create mode 100644 drivers/net/tap/rte_eth_tap.h
 create mode 100644 drivers/net/tap/tap_flow.c
 create mode 100644 drivers/net/tap/tap_flow.h
 create mode 100644 drivers/net/tap/tap_netlink.c
 create mode 100644 drivers/net/tap/tap_netlink.h
 create mode 100644 drivers/net/tap/tap_tcmsgs.c
 create mode 100644 drivers/net/tap/tap_tcmsgs.h
Signature · 1 line
2.12.0.306.g4a9b9b3