Skip to content

staging: bcm2835-audio: fix coding style issues

Aishwarya Pant outreachy 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4staging: bcm2835-audio: Replace kmalloc with kzallocdrivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c+1 -20 replies
2/4staging: bcm2835-audio: replace null with error pointer valuedrivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c+4 -40 replies
3/4staging: bcm2835-audio: propagate PTR_ERR value instead of -EPERMdrivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c+1 -10 replies
4/4staging: bcm2835-audio: use conditional only for error casedrivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c+23 -231 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] staging: bcm2835-audio: fix coding style issues

This patchset makes the following changes:
- Replace kmalloc and memset with kzalloc
- Replace null return value with PTR_ERR values
- Propagate the PTR_ERR values forward instead of a hardcoded value for easier debugging
- Replace if (success) else { } after kmalloc with if (error) to fail fast.

Aishwarya Pant (4):
staging: bcm2835-audio: Replace kmalloc with kzalloc
staging: bcm2835-audio: replace null with error pointer value
staging: bcm2835-audio: propagate PTR_ERR value instead of -EPERM
staging: bcm2835-audio: use conditional only for error case

 .../vc04_services/bcm2835-audio/bcm2835-vchiq.c    | 59 +++++++++++-----------
 1 file changed, 29 insertions(+), 30 deletions(-)
Signature · 1 line
2.7.4