Skip to content

staging: speakup: i18n.c: Refactor conditionals and change return type

Narcisa Ana Maria Vasile outreachy 3 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesIn review
  2. v22 patches 1 replySuperseded
  3. v12 patches 2 repliesSuperseded

Changes in v3 from the cover letter

Replace numeric value '1' with boolean 'true'

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2staging: speakup: i18n.c: Change return type from int to booldrivers/staging/speakup/i18n.c+12 -110 replies
2/2staging: speakup: i18n.c: Refactor conditionals in spk_msg_setdrivers/staging/speakup/i18n.c+20 -241 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJulia Lawall
SeriesA-b
1/2
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] staging: speakup: i18n.c: Refactor conditionals and change return type

Change return type from int to bool and refactor code for clarity.

---
Changes in v3:
Replace numeric value '1' with boolean 'true'

Changes in v2:
- Update documentation for compare_specifiers and fmt_validate
- Make commit messages more clear
- Rewrite condition without using '!'
- Fit function call on single line

Narcisa Ana Maria Vasile (2):
staging: speakup: i18n.c: Change return type from int to bool
staging: speakup: i18n.c: Refactor conditionals in spk_msg_set

drivers/staging/speakup/i18n.c | 67 ++++++++++++++++++++----------------------

1 file changed, 32 insertions(+), 35 deletions(-)
    -- 
    1.9.1