Skip to content

staging: vc04_services: clean up anonymous field declarations

Aishwarya Pant outreachy 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2staging: bcm2835-audio: remove anonymous field declarationsdrivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c+10 -101 reply
2/2staging: bcm2835-camera: remove anonymous field declarationsdrivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c+10 -103 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] staging: vc04_services: clean up anonymous field declarations

This patchset replaces anonymous field declarations for the typedef SERVICE_CREATION_T with explicit field declarations in the drivers bcm2835-audio and bcm2835-camera.

typedef struct {
        struct vchi_version version;
        int32_t service_id;
        VCHI_CONNECTION_T *connection;
        uint32_t rx_fifo_size;
        uint32_t tx_fifo_size;
        VCHI_CALLBACK_T callback;
        void *callback_param;
        /* client intends to receive bulk transfers of
                odd lengths or into unaligned buffers */
        int32_t want_unaligned_bulk_rx;
        /* client intends to transmit bulk transfers of
                odd lengths or out of unaligned buffers */
        int32_t want_unaligned_bulk_tx;
        /* client wants to check CRCs on (bulk) xfers.
                Only needs to be set at 1 end - will do both directions. */
        int32_t want_crc;
} SERVICE_CREATION_T;

** HERE ***

Aishwarya Pant (2):
staging: bcm2835-audio: remove anonymous field declarations
staging: bcm2835-camera: remove anonymous field declarations

 .../vc04_services/bcm2835-audio/bcm2835-vchiq.c      | 20 ++++++++++----------
 .../vc04_services/bcm2835-camera/mmal-vchiq.c        | 20 ++++++++++----------
 2 files changed, 20 insertions(+), 20 deletions(-)
Signature · 1 line
2.7.4