Skip to content

drm/omap: Remove CONFIG_DRM_OMAP_NUM_CRTCS, cleanup & CTM

Jyri Sarha dri-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 6 repliesIn review
  2. v35 patches 0 repliesSuperseded
  3. v22 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches2 repliesSuperseded

Changes in v4 from the cover letter

- Rebased on top Tomi Valkeinen's latest omap-drm series:
https://lists.freedesktop.org/archives/dri-devel/2017-March/136770.html
- Adds:
- drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/omap: Get rid of DRM_OMAP_NUM_CRTCS config optiondrivers/gpu/drm/omapdrm/Kconfig drivers/gpu/drm/omapdrm/omap_drv.c+16 -521 reply
2/6drm/omap: Rename enum omap_plane to enum omap_plane_iddrivers/gpu/drm/omapdrm/dss/dispc.c drivers/gpu/drm/omapdrm/dss/dispc.h drivers/gpu/drm/omapdrm/dss/dss.h +3 more+117 -1031 reply
3/6drm/omap: Fix one ugly indentation style break left by coccinelledrivers/gpu/drm/omapdrm/dss/dispc.c+2 -31 reply
4/6drm/omap: Remove the obsolete #define omap_plane _omap_plane hackdrivers/gpu/drm/omapdrm/omap_plane.c+1 -71 reply
5/6drm/omap: Major omap_modeset_init() cleanupdrivers/gpu/drm/omapdrm/omap_crtc.c drivers/gpu/drm/omapdrm/omap_drv.c drivers/gpu/drm/omapdrm/omap_drv.h +1 more+86 -1390 replies
6/6drm/omap: Implement CTM property for CRTC using OVL managers CPR matrixdrivers/gpu/drm/omapdrm/omap_crtc.c+29 -11 reply

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchLaurent Pinchart
1/6R-b
2/6A-b
3/6A-b
4/6R-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/6] drm/omap: Remove CONFIG_DRM_OMAP_NUM_CRTCS, cleanup & CTM

The first patch removes CONFIG_DRM_OMAP_NUM_CRTCS config option. The patches number 2-4 gets rid of annoying name collision between dss backend and omapdrm. The second last patch cleans up the unnecessary complexity from omap_modeset_init(). And finally the last implements CRTC's CTM matrix propety by using DSS DISPC's Color Phase Rotation unit.

Changes since v3:
- Rebased on top Tomi Valkeinen's latest omap-drm series:
https://lists.freedesktop.org/archives/dri-devel/2017-March/136770.html
- Adds:
- drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

Changes since v2:
- drm/omap: Get rid of DRM_OMAP_NUM_CRTCS config option
- No change
- Added:
- drm/omap: Rename enum omap_plane to enum omap_plane_id
- drm/omap: Fix ugliest indentation style breaks from previous patch
- drm/omap: Remove the obsolete #define omap_plane _omap_plane hack
- drm/omap: Major omap_modeset_init() cleanup
- use memset() to reset omap_crtcs[] in omap_crtc_pre_init()
- make the mapping between omapdrm plane index and dss plane id explicit

Changes since first version:
- drm/omapdrm: Get rid of DRM_OMAP_NUM_CRTCS config option
- drm/omapdrm: -> drm/omap:
- Drop:
- drm/omapdrm: Change possible_crtcs to possible_crtcs_for_planes
- drm/omapdrm: Separate ids for planes and CRTCs in omap_modeset_init()
- Add:
- drm/omap: Major omap_modeset_init() cleanup

Jyri Sarha (6):
drm/omap: Get rid of DRM_OMAP_NUM_CRTCS config option drm/omap: Rename enum omap_plane to enum omap_plane_id drm/omap: Fix one ugly indentation style break left by coccinelle drm/omap: Remove the obsolete #define omap_plane _omap_plane hack drm/omap: Major omap_modeset_init() cleanup
drm/omap: Implement CTM property for CRTC using OVL managers CPR
matrix

 drivers/gpu/drm/omapdrm/Kconfig            |   9 --
 drivers/gpu/drm/omapdrm/dss/dispc.c        | 123 +++++++++--------
 drivers/gpu/drm/omapdrm/dss/dispc.h        |  62 ++++-----
 drivers/gpu/drm/omapdrm/dss/dss.h          |   5 +-
 drivers/gpu/drm/omapdrm/dss/dss_features.c |   6 +-
 drivers/gpu/drm/omapdrm/dss/dss_features.h |   6 +-
 drivers/gpu/drm/omapdrm/dss/omapdss.h      |  17 +--
 drivers/gpu/drm/omapdrm/omap_crtc.c        |  50 ++++++-
 drivers/gpu/drm/omapdrm/omap_drv.c         | 212 +++++++----------------------
 drivers/gpu/drm/omapdrm/omap_drv.h         |   4 +-
 drivers/gpu/drm/omapdrm/omap_plane.c       |  32 +++--
 11 files changed, 236 insertions(+), 290 deletions(-)
Signature · 6 lines
1.9.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel