Skip to content

mm: page_alloc: style neatenings

Joe Perches linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15mm: page_alloc: whitespace neateningmm/page_alloc.c+27 -270 replies
2/15mm: page_alloc: align arguments to parenthesismm/page_alloc.c+276 -2763 replies
3/15mm: page_alloc: fix brace positionsmm/page_alloc.c+0 -50 replies
4/15mm: page_alloc: fix blank linesmm/page_alloc.c+27 -90 replies
5/15mm: page_alloc: Move __meminitdata and __initdata usesmm/page_alloc.c+8 -80 replies
6/15mm: page_alloc: Use unsigned int instead of unsignedmm/page_alloc.c+6 -60 replies
7/15mm: page_alloc: Move labels to column 1mm/page_alloc.c+4 -40 replies
8/15mm: page_alloc: Fix typo acording -> according & the the -> to themm/page_alloc.c+1 -10 replies
9/15mm: page_alloc: Use the common commenting stylemm/page_alloc.c+4 -20 replies
10/15mm: page_alloc: 80 column neateningmm/page_alloc.c+157 -1021 reply
11/15mm: page_alloc: Move EXPORT_SYMBOL usesmm/page_alloc.c+16 -170 replies
12/15mm: page_alloc: Avoid pointer comparisons to NULLmm/page_alloc.c+4 -40 replies
13/15mm: page_alloc: Remove unnecessary parenthesesmm/page_alloc.c+3 -30 replies
14/15mm: page_alloc: Use octal permissionsmm/page_alloc.c+1 -10 replies
15/15mm: page_alloc: Move logical continuations to EOLmm/page_alloc.c+11 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/15] mm: page_alloc: style neatenings

Just neatening. Maybe useful, maybe not. Mostly whitespace changes.

There are still many checkpatch messages that should probably be ignored.

Before:

$ ./scripts/checkpatch.pl --strict --terse --nosummary --show-types \
	-f mm/page_alloc.c | \
  cut -f4 -d":" | sort | uniq -c | sort -rn
    144 PARENTHESIS_ALIGNMENT
     38 SPLIT_STRING
     36 LINE_SPACING
     32 LONG_LINE
     28 SPACING
     14 LONG_LINE_COMMENT
     14 BRACES
     13 LOGGING_CONTINUATION
     12 PREFER_PR_LEVEL
      8 MISPLACED_INIT
      7 EXPORT_SYMBOL
      7 AVOID_BUG
      6 UNSPECIFIED_INT
      5 MACRO_ARG_PRECEDENCE
      4 MULTIPLE_ASSIGNMENTS
      4 LOGICAL_CONTINUATIONS
      4 COMPARISON_TO_NULL
      4 CAMELCASE
      3 UNNECESSARY_PARENTHESES
      3 PRINTK_WITHOUT_KERN_LEVEL
      3 MACRO_ARG_REUSE
      2 UNDOCUMENTED_SETUP
      2 MEMORY_BARRIER
      2 BLOCK_COMMENT_STYLE
      1 VOLATILE
      1 TYPO_SPELLING
      1 SYMBOLIC_PERMS
      1 SUSPECT_CODE_INDENT
      1 SPACE_BEFORE_TAB
      1 FUNCTION_ARGUMENTS
      1 CONSTANT_COMPARISON
      1 CONSIDER_KSTRTO

After:

$ ./scripts/checkpatch.pl --strict --terse --nosummary --show-types \
	-f mm/page_alloc.c | \
  cut -f4 -d":" | sort | uniq -c | sort -rn
     43 SPLIT_STRING
     21 LONG_LINE
     14 LONG_LINE_COMMENT
     13 LOGGING_CONTINUATION
     12 PREFER_PR_LEVEL
      8 PRINTK_WITHOUT_KERN_LEVEL
      7 AVOID_BUG
      5 MACRO_ARG_PRECEDENCE
      4 MULTIPLE_ASSIGNMENTS
      4 CAMELCASE
      3 MACRO_ARG_REUSE
      2 UNDOCUMENTED_SETUP
      2 MEMORY_BARRIER
      2 LEADING_SPACE
      1 VOLATILE
      1 SPACING
      1 FUNCTION_ARGUMENTS
      1 EXPORT_SYMBOL
      1 CONSTANT_COMPARISON
      1 CONSIDER_KSTRTO

Joe Perches (15):
mm: page_alloc: whitespace neatening
mm: page_alloc: align arguments to parenthesis
mm: page_alloc: fix brace positions
mm: page_alloc: fix blank lines
mm: page_alloc: Move __meminitdata and __initdata uses
mm: page_alloc: Use unsigned int instead of unsigned
mm: page_alloc: Move labels to column 1
mm: page_alloc: Fix typo acording -> according & the the -> to the
mm: page_alloc: Use the common commenting style
mm: page_alloc: 80 column neatening
mm: page_alloc: Move EXPORT_SYMBOL uses
mm: page_alloc: Avoid pointer comparisons to NULL
mm: page_alloc: Remove unnecessary parentheses
mm: page_alloc: Use octal permissions
mm: page_alloc: Move logical continuations to EOL

 mm/page_alloc.c | 845 ++++++++++++++++++++++++++++++--------------------------
 1 file changed, 458 insertions(+), 387 deletions(-)
Signature · 7 lines
2.10.0.rc2.1.g053435c

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>