dim: shellcheck fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest10 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | dim: add make target to shellcheck dimMakefile | +24 | 0 replies | |
| 2/10 | dim: quote check for non-zero stringMakefile dim | +1 | 0 replies | |
| 3/10 | dim: replace expr with $((..))Makefile dim | +1 | 0 replies | |
| 4/10 | dim: use $* instead of $@ within stringMakefile dim | +2 | 0 replies | |
| 5/10 | dim: double quote array expansionsMakefile dim | +4 | 0 replies | |
| 6/10 | dim: quote expressions using { }Makefile dim | +8 | 0 replies | |
| 7/10 | dim: add double quotes to prevent glob interpretationMakefile dim | +1 | 0 replies | |
| 8/10 | dim: prevent * from becoming optionsMakefile dim | +1 | 0 replies | |
| 9/10 | dim: avoid useless cat in apply-branchMakefile dim | +2 | 0 replies | |
| 10/10 | dim: Replace `..` with $(..)Makefile dim | +55 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [dim PATCH 00/10] dim: shellcheck fixes
Noticing that 64a54c5e1a5d ("dim: Add add-link command") added a condition that is always true (if [ -n $foo ]), despite my review of the patch, I refreshed some of my old patches to fix issues that can be caught by shellcheck.
Starting from patch 1, the minimal merge criteria for any new dim patches is that 'make shellcheck' passes.
I add shellcheck exceptions for starters, so there are no errors reported, and then remove the exceptions by fixing them one by one. I'm not sure if we'll ever fix them all, but let's at least make sure we're not adding any new silly mistakes.
BR,
Jani.
Jani Nikula (10):
dim: add make target to shellcheck dim
dim: quote check for non-zero string
dim: replace expr with $((..))
dim: use $* instead of $@ within string
dim: double quote array expansions
dim: quote expressions using { }
dim: add double quotes to prevent glob interpretation
dim: prevent * from becoming options
dim: avoid useless cat in apply-branch
dim: Replace .. with $(..)
Makefile | 16 +++++++ dim | 143 ++++++++++++++++++++++++++++++++------------------------------- 2 files changed, 88 insertions(+), 71 deletions(-)
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx