Skip to content

dim: shellcheck v0.4.4 fixes

Jani Nikula intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8dim: declare and assign separatelydim+2 -20 replies
2/8dim: use [ p ] || [ q ] instead of test -a/-odim+2 -20 replies
3/8dim: use read -r optiondim+3 -30 replies
4/8dim: silence shellcheck warning about sourced filesdim+3 -10 replies
5/8dim: avoid errors with rm $foo/ expanding to /dim+12 -47 replies
6/8dim: pipe dim_cite output directly instead of using echoMakefile dim+1 -20 replies
7/8dim: use grep -c instead of grep|wcMakefile dim+1 -22 replies
8/8dim: abstract -i interactive pause to a functionMakefile dim+7 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] dim: shellcheck v0.4.4 fixes

Shellcheck version 0.4.4 complains more than the earlier version I was using previously. Shut it up harder.

BR,
Jani.

Jani Nikula (8):
dim: declare and assign separately
dim: use [ p ] || [ q ] instead of test -a/-o
dim: use read -r option
dim: silence shellcheck warning about sourced files
dim: avoid errors with rm $foo/ expanding to /
dim: pipe dim_cite output directly instead of using echo
dim: use grep -c instead of grep|wc
dim: abstract -i interactive pause to a function

 Makefile |  4 ----
 dim      | 46 +++++++++++++++++++++++++++++++---------------
 2 files changed, 31 insertions(+), 19 deletions(-)
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx