#10618: Increase oe-selftest coverage of wic codebase (first part)

Hi,

The main goal of these changes was to increase test coverage by testing rawcopy plugin, which was not covered by the wic test suite. While working on it I found and fixed quite nasty bug in sparse_copy API and made set of other important changes to make the test case working.

I've also removed rootfs_pcbios_ext plugin, which was broken for a long time and cleaned up wic test suite to keep it in a good shape.

The goal set in bugzilla issue #10618 is to increase test coverage to at least 80%. Now it's only 74%, so more changes will have to be made. This patchset is just a first part of the work in this area.

Note for project maintainers:
This patchset is based on Maciej's "enhancements for non-x86 MACHINE support & fixed-size tests"
patchset: http://lists.openembedded.org/pipermail/openembedded-core/2017-March/134410.html so, please merge it in the right order.

The following changes since commit e07ca8bd2bd4a8fa1fb9a0f3a8d9ff9a8f9c46c8:

wic: selftest: add tests for --fixed-size partition flags (2017-03-21 15:17:24 +0200)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ed/wic/wip
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wic/wip

Ed Bartosh (10):
wic: remove rootfs_pcbios_ext plugin
wic: don't set creator.bootimg_dir in plugins
wic: use kernel_dir instead of bootimg_dir
wic: fix bug in sparse_copy
wic: use STAGING_DATADIR as a default for bootimg_dir
wic: remove empty plugin methods
wic: improve getting syslinux path
oe-selftest: test wic rawcopy plugin
selftest: pylinted wic test suite.
oe-selftest: add test_rawcopy_plugin test case

 meta-selftest/wic/test_rawcopy_plugin.wks.in       |   6 +
 meta/lib/oeqa/selftest/wic.py                      |  84 +++++---
 scripts/lib/wic/filemap.py                         |   1 +
 scripts/lib/wic/plugins/source/bootimg-efi.py      |  16 +-
 .../lib/wic/plugins/source/bootimg-partition.py    |  32 +---
 scripts/lib/wic/plugins/source/bootimg-pcbios.py   |  53 ++---
 scripts/lib/wic/plugins/source/fsimage.py          |  19 --
 scripts/lib/wic/plugins/source/rawcopy.py          |  29 +--
 .../lib/wic/plugins/source/rootfs_pcbios_ext.py    | 213 ---------------------
 scripts/wic                                        |   3 +-
 10 files changed, 113 insertions(+), 343 deletions(-)
 create mode 100644 meta-selftest/wic/test_rawcopy_plugin.wks.in
 delete mode 100644 scripts/lib/wic/plugins/source/rootfs_pcbios_ext.py

2.1.4