RBD reopen, read_only cleanup
Status from this message: Applied to my block branch:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest8 patches 3 repliesApplied
- v19 patches 19 repliesSuperseded
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | block: add bdrv_set_read_only() helper functionblock.c block/ block/ +4 more | +12 | 0 replies | |
| 2/8 | block: do not set BDS read_only if copy_on_read enabledblock.c block/ block/ +4 more | +48 | 0 replies | |
| 3/8 | block: honor BDRV_O_ALLOW_RDWR when clearing bs->read_onlyblock.c | +7 | 0 replies | |
| 4/8 | block: code movementblock.c | +5 | 0 replies | |
| 5/8 | block: introduce bdrv_can_set_read_only()block.c include/ | +14 | 0 replies | |
| 6/8 | block: use bdrv_can_set_read_only() during reopenblock.c | +8 | 0 replies | |
| 7/8 | block/rbd - update variable names to more apt namesblock/ | +17 | 0 replies | |
| 8/8 | block/rbd: Add support for reopen()block/ | +21 | 0 replies |
Reviews trailers per patch
4 of 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Stefan Hajnoczi | John Snow |
|---|---|---|
| Series | R-b | R-b |
| 1/8 | R-b | |
| 2/8 | ||
| 3/8 | ||
| 4/8 | R-b | R-b |
| 5/8 | ||
| 6/8 | ||
| 7/8 | R-b | |
| 8/8 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v2 for-2.10 0/8] RBD reopen, read_only cleanup
Changes from v1:
Patch 2: Has v1 patch 8 (do not blindly xset bs->read_only) squashed into it
(thanks Stefan)
COW -> "copy-on-read" (Thanks John)
Drop unneeded call in vvfat, and bypass enable_write_target (Stefan)
Patch 5: Rename bdrv_try_... to bdrv_can_set_read_only() (Thanks John, Stefan)
Patch 6: Use "reopen_state->flags" not "reopen_state->bs->open_flags"
(Thanks John)
This series does two things:
1.) Cleans up some of the logic behind setting the read_only flag
for a BDS in the block layer, so that it is done consistently (and rules are applied consistently), and
2.) Adds .bdrv_reopen_prepare() implementation for RBD, so that block
jobs can be run on backing chains that have rbd protocol nodes.
Jeff Cody (8):
block: add bdrv_set_read_only() helper function
block: do not set BDS read_only if copy_on_read enabled
block: honor BDRV_O_ALLOW_RDWR when clearing bs->read_only
block: code movement
block: introduce bdrv_can_set_read_only()
block: use bdrv_can_set_read_only() during reopen block/rbd - update variable names to more apt names block/rbd: Add support for reopen()
block.c | 56 +++++++++++++++++++++++++++++++++++--------- block/bochs.c | 5 +++- block/cloop.c | 5 +++- block/dmg.c | 6 ++++- block/rbd.c | 65 +++++++++++++++++++++++++++++++++++++-------------- block/vvfat.c | 19 +++++++++++---- include/block/block.h | 2 ++ 7 files changed, 123 insertions(+), 35 deletions(-)
Signature · 1 line
2.9.3