Skip to content

bitbake-diffsigs fixes/improvements

Paul Eggleton bitbake-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11bitbake-diffsigs: fix -t picking wrong files to comparebin/bitbake-diffsigs+3 -30 replies
2/11lib/bb/siggen: add missing path separator to cleaned pathslib/bb/siggen.py+1 -10 replies
3/11bitbake-diffsigs: properly report which signature is missingbin/bitbake-diffsigs+7 -31 reply
4/11bitbake-diffsigs: drop naive logic for removing duplicate filesbin/bitbake-diffsigs+0 -160 replies
5/11lib/bb/siggen: show a diff when dumping changes to multi-line valuesbin/bitbake-diffsigs lib/bb/siggen.py+14 -20 replies
6/11lib/bb/siggen: don't show unchanged runtaskdeps listlib/bb/siggen.py+6 -20 replies
7/11bitbake-diffsigs: change to use argparsebin/bitbake-diffsigs+33 -310 replies
8/11bitbake-diffsigs: add an option to find and compare specific signaturesbin/bitbake-diffsigs+59 -360 replies
9/11lib/bb/siggen: add collapsed mode to compare_sigfiles()lib/bb/siggen.py+28 -232 replies
10/11lib/bb/siggen: show word-diff for single-line values containing spacesLICENSE lib/bb/siggen.py lib/simplediff/LICENSE +1 more+259 -10 replies
11/11bitbake-diffsigs: colourise outputbin/bitbake-diffsigs lib/bb/siggen.py+85 -340 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/11] bitbake-diffsigs fixes/improvements

As part of an effort to add task signature recording and comparison to buildhistory in OE, I went digging into bitbake-diffsigs and the code that supports it and discovered that unfortunately it had a number of bugs - in particular the -t option despite being around for a while and having numerous band-aids applied in the past still wasn't really working properly. I have to take a big chunk of the responsibility for this as I wrote the thing in the first place. This patchset corrects most of the issues that I found and also makes a number of improvements to the readability of the output.

NOTE: there are a few corresponding changes required in OE-Core that I am about to send out, these should be applied at the same time.

The following changes since commit 751c9dc51fd01fa64a1ff37ba2638110335f71af:

fetch/local: Drop FILESDIR (2017-04-05 09:38:01 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib paule/bb-sigstuff
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=paule/bb-sigstuff

Paul Eggleton (11):
bitbake-diffsigs: fix -t picking wrong files to compare lib/bb/siggen: add missing path separator to cleaned paths
bitbake-diffsigs: properly report which signature is missing
bitbake-diffsigs: drop naive logic for removing duplicate files lib/bb/siggen: show a diff when dumping changes to multi-line values lib/bb/siggen: don't show unchanged runtaskdeps list
bitbake-diffsigs: change to use argparse
bitbake-diffsigs: add an option to find and compare specific signatures lib/bb/siggen: add collapsed mode to compare_sigfiles() lib/bb/siggen: show word-diff for single-line values containing spaces
bitbake-diffsigs: colourise output

 LICENSE                    |   2 +
 bin/bitbake-diffsigs       | 175 +++++++++++++++++++++------------------
 lib/bb/siggen.py           | 166 +++++++++++++++++++++++++++++--------
 lib/simplediff/LICENSE     |  22 +++++
 lib/simplediff/__init__.py | 198 +++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 453 insertions(+), 110 deletions(-)
 create mode 100644 lib/simplediff/LICENSE
 create mode 100644 lib/simplediff/__init__.py
Signature · 1 line
2.9.3