Remove struct eth_driver
Status from this message: Applied, thanks
Get series with b4
b4 am [email protected]Versions newest first
Changes in v2 from the cover letter
* Removed the patch "net/vmxnet3: use library function for DMA zone reserve" It is essentially duplicating the following commit:
04df93d1edac ("net/vmxnet3: fix queue size changes")
* Fixed header includes for mlx4 and mlx5 PMD
* Followed the changes of the series for new PMDs (AVP, liquidio)
* Made KNI use the new API
* Made PCAP use the new API
* Fixed undefined behavior on vdev driver arg parsing
* Fixed virtual_pmd for unit test
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/42 | eal: add name field to generic devicelib/ lib/ lib/ +3 more | +13 | 0 replies | |
| 2/42 | eal: parse "driver" device argument before probing driverslib/ | +46 | 2 replies | |
| 3/42 | net/nfp: use library function for DMA zone reservedrivers/ | +6 | 0 replies | |
| 4/42 | ether: add allocation helper for virtual driverslib/ lib/ | +86 | 0 replies | |
| 5/42 | net/tap: use ethdev allocation helper for virtual devicesdrivers/ | +13 | 0 replies | |
| 6/42 | net/vhost: use ethdev allocation helper for virtual devicesdrivers/ | +26 | 0 replies | |
| 7/42 | net/virtio: use ethdev allocation helper for virtual devicesdrivers/ | +5 | 0 replies | |
| 8/42 | net/af_packet: use ethdev allocation helper for virtual devicesdrivers/ | +19 | 0 replies | |
| 9/42 | app/test: don't short-circuit null device creationdrivers/ test/ | +3 | 0 replies | |
| 10/42 | net/null: internalize eth_dev_null_create()drivers/ drivers/ drivers/ +2 more | +2 | 0 replies | |
| 11/42 | net/null: use ethdev allocation helper for virtual devicesdrivers/ | +17 | 0 replies | |
| 12/42 | net/bonding: make bonding API call through EAL on create/freedrivers/ drivers/ drivers/ | +194 | 0 replies | |
| 13/42 | net/bonding: use ethdev allocation helper for virtual devicesdrivers/ | +3 | 0 replies | |
| 14/42 | net/kni: use ethdev allocation helper for virtual devicesdrivers/ | +15 | 0 replies | |
| 15/42 | net/pcap: use ethdev allocation helper for virtual devicesdrivers/ | +27 | 0 replies | |
| 16/42 | ethdev: add PCI driver helperslib/ lib/ | +152 | 0 replies | |
| 17/42 | net/virtio: Don't use eth_driverdrivers/ | +21 | 0 replies | |
| 18/42 | net/bnx2x: Don't use eth_driverdrivers/ drivers/ | +45 | 0 replies | |
| 19/42 | net/bnxt: Don't use eth_driverdrivers/ | +23 | 0 replies | |
| 20/42 | net/cxgbe: Don't use eth_driverdrivers/ drivers/ | +22 | 0 replies | |
| 21/42 | net/em: Don't use eth_driverdrivers/ | +19 | 0 replies | |
| 22/42 | net/igb: Don't use eth_driverdrivers/ | +38 | 0 replies | |
| 23/42 | net/ena: Don't use eth_driverdrivers/ | +19 | 0 replies | |
| 24/42 | net/enic: Don't use eth_driverdrivers/ | +19 | 0 replies | |
| 25/42 | net/fm10k: Don't use eth_driverdrivers/ | +19 | 0 replies | |
| 26/42 | net/i40e: Don't use eth_driverdrivers/ drivers/ | +23 | 0 replies | |
| 27/42 | net/i40evf: Don't use eth_driverdrivers/ | +20 | 0 replies | |
| 28/42 | net/ixgbe: Don't use eth_driverdrivers/ | +40 | 0 replies | |
| 29/42 | net/mlx: Don't reference eth_driverdrivers/ drivers/ | +22 | 0 replies | |
| 30/42 | net/nfp: Don't use eth_driverdrivers/ | +19 | 0 replies | |
| 31/42 | net/qede: Don't use eth_driverdrivers/ drivers/ | +37 | 0 replies | |
| 32/42 | net/sfc: Don't use eth_driverdrivers/ | +21 | 0 replies | |
| 33/42 | net/szedata2: Don't use eth_driverdrivers/ | +19 | 0 replies | |
| 34/42 | net/thunderx: Don't use eth_driverdrivers/ | +19 | 0 replies | |
| 35/42 | net/vmxnet3: Don't use eth_driverdrivers/ | +19 | 0 replies | |
| 36/42 | net/avp: Don't use eth_driverdrivers/ | +32 | 1 reply | |
| 37/42 | net/liquidio: Don't use eth_driverdrivers/ | +33 | 0 replies | |
| 38/42 | ethdev: remove unused ethdev PCI probe/removelib/ lib/ lib/ +1 more | +11 | 2 replies | |
| 39/42 | ethdev: remove unused ethdev driverdrivers/ drivers/ lib/ +2 more | +0 | 0 replies | |
| 40/42 | test: remove unused ethdev drivertest/ | +3 | 0 replies | |
| 41/42 | ethdev: remove PCI specific helper from generic ethdev headerdrivers/ lib/ lib/ +2 more | +33 | 0 replies | |
| 42/42 | ethdev: don't include PCI headerlib/ | +2 | 0 replies |
Reviews trailers per patch
1 of 42 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Allain Legacy | Stephen Hemminger | Ed Czeck |
|---|---|---|---|
| Series | A-b | A-b | |
| 1/42 | |||
| 2/42 | |||
| 3/42 | |||
| 4/42 | |||
| 5/42 | |||
| 6/42 | |||
| 7/42 | |||
| 8/42 | |||
| 9/42 | |||
| 10/42 | |||
| 11/42 | |||
| 12/42 | |||
| 13/42 | |||
| 14/42 | |||
| 15/42 | |||
| 16/42 | |||
| 17/42 | |||
| 18/42 | |||
| 19/42 | |||
| 20/42 | |||
| 21/42 | |||
| 22/42 | |||
| 23/42 | |||
| 24/42 | |||
| 25/42 | |||
| 26/42 | |||
| 27/42 | |||
| 28/42 | |||
| 29/42 | |||
| 30/42 | |||
| 31/42 | |||
| 32/42 | |||
| 33/42 | |||
| 34/42 | |||
| 35/42 | |||
| 36/42 | A-b | ||
| 37/42 | |||
| 38/42 | |||
| 39/42 | |||
| 40/42 | |||
| 41/42 | |||
| 42/42 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 00/42] Remove struct eth_driver
I rebased the following work of Jan:
This series is removing the PCI specific struct eth_driver from rte_ether. The PCI drivers are changed to use the newly introduced header-only helpers instead. Although the virtual drivers did not make use of the ethdev's driver field they are converted to use the VDEV specific allocation helpers. The motivation for this change is to properly embed a reference to the generic rte_device in the ethdev.
The series is based on:
* http://dpdk.org/dev/patchwork/patch/20416/
* http://dpdk.org/dev/patchwork/patch/20417/
* The "Rework vdev probing to use rte_bus infrastructure" series
* http://dpdk.org/dev/patchwork/patch/21058/
Changes in v2:
* Removed the patch "net/vmxnet3: use library function for DMA zone reserve" It is essentially duplicating the following commit:
04df93d1edac ("net/vmxnet3: fix queue size changes")
* Fixed header includes for mlx4 and mlx5 PMD
* Followed the changes of the series for new PMDs (AVP, liquidio)
* Made KNI use the new API
* Made PCAP use the new API
* Fixed undefined behavior on vdev driver arg parsing
* Fixed virtual_pmd for unit test
Gaetan Rivet (5):
net/kni: use ethdev allocation helper for virtual devices net/pcap: use ethdev allocation helper for virtual devices net/avp: Don't use eth_driver
net/liquidio: Don't use eth_driver
test: remove unused ethdev driver
Jan Blunck (37):
eal: add name field to generic device
eal: parse "driver" device argument before probing drivers net/nfp: use library function for DMA zone reserve
ether: add allocation helper for virtual drivers net/tap: use ethdev allocation helper for virtual devices net/vhost: use ethdev allocation helper for virtual devices net/virtio: use ethdev allocation helper for virtual devices net/af_packet: use ethdev allocation helper for virtual devices app/test: don't short-circuit null device creation net/null: internalize eth_dev_null_create()
net/null: use ethdev allocation helper for virtual devices net/bonding: make bonding API call through EAL on create/free net/bonding: use ethdev allocation helper for virtual devices
ethdev: add PCI driver helpers
net/virtio: Don't use eth_driver
net/bnx2x: Don't use eth_driver
net/bnxt: Don't use eth_driver
net/cxgbe: Don't use eth_driver
net/em: Don't use eth_driver
net/igb: Don't use eth_driver
net/ena: Don't use eth_driver
net/enic: Don't use eth_driver
net/fm10k: Don't use eth_driver
net/i40e: Don't use eth_driver
net/i40evf: Don't use eth_driver
net/ixgbe: Don't use eth_driver
net/mlx: Don't reference eth_driver
net/nfp: Don't use eth_driver
net/qede: Don't use eth_driver
net/sfc: Don't use eth_driver
net/szedata2: Don't use eth_driver
net/thunderx: Don't use eth_driver
net/vmxnet3: Don't use eth_driver
ethdev: remove unused ethdev PCI probe/remove
ethdev: remove unused ethdev driver
ethdev: remove PCI specific helper from generic ethdev header
ethdev: don't include PCI header
drivers/net/af_packet/rte_eth_af_packet.c | 42 +++---- drivers/net/avp/avp_ethdev.c | 43 +++++-- drivers/net/bnx2x/bnx2x_ethdev.c | 64 ++++++---- drivers/net/bnx2x/bnx2x_rxtx.c | 2 +- drivers/net/bnxt/bnxt_ethdev.c | 36 ++++-- drivers/net/bonding/rte_eth_bond_api.c | 171 ++++---------------------- drivers/net/bonding/rte_eth_bond_args.c | 2 +- drivers/net/bonding/rte_eth_bond_pmd.c | 160 +++++++++++++++++++++++-- drivers/net/cxgbe/cxgbe_ethdev.c | 29 +++-- drivers/net/cxgbe/cxgbe_main.c | 2 +- drivers/net/cxgbe/sge.c | 6 +- drivers/net/e1000/em_ethdev.c | 30 +++-- drivers/net/e1000/igb_ethdev.c | 60 ++++++---- drivers/net/ena/ena_ethdev.c | 29 +++-- drivers/net/enic/enic_ethdev.c | 29 +++-- drivers/net/fm10k/fm10k_ethdev.c | 30 +++-- drivers/net/i40e/i40e_ethdev.c | 36 +++--- drivers/net/i40e/i40e_ethdev_vf.c | 31 +++-- drivers/net/i40e/i40e_fdir.c | 2 +- drivers/net/ixgbe/ixgbe_ethdev.c | 66 +++++++---- drivers/net/kni/rte_eth_kni.c | 39 +++--- drivers/net/liquidio/lio_ethdev.c | 44 +++++-- drivers/net/mlx4/mlx4.c | 24 ++-- drivers/net/mlx5/mlx5.c | 24 ++-- drivers/net/nfp/nfp_net.c | 59 ++++----- drivers/net/null/Makefile | 7 +- drivers/net/null/rte_eth_null.c | 55 +++------ drivers/net/null/rte_eth_null.h | 40 ------- drivers/net/null/rte_pmd_null_version.map | 7 -- drivers/net/pcap/rte_eth_pcap.c | 62 +++++----- drivers/net/qede/qede_ethdev.c | 60 ++++++---- drivers/net/qede/qede_ethdev.h | 1 + drivers/net/ring/rte_eth_ring.c | 1 - drivers/net/sfc/sfc_ethdev.c | 34 ++++-- drivers/net/szedata2/rte_eth_szedata2.c | 29 +++-- drivers/net/tap/rte_eth_tap.c | 38 ++---- drivers/net/thunderx/nicvf_ethdev.c | 29 +++-- drivers/net/vhost/rte_eth_vhost.c | 54 ++++----- drivers/net/virtio/virtio_ethdev.c | 34 ++++-- drivers/net/virtio/virtio_user_ethdev.c | 20 +--- drivers/net/vmxnet3/vmxnet3_ethdev.c | 30 +++-- lib/librte_eal/bsdapp/eal/eal_pci.c | 3 + lib/librte_eal/common/eal_common_dev.c | 3 + lib/librte_eal/common/eal_common_vdev.c | 53 ++++++++- lib/librte_eal/common/include/rte_dev.h | 1 + lib/librte_eal/common/include/rte_pci.h | 1 + lib/librte_eal/linuxapp/eal/eal_pci.c | 3 + lib/librte_ether/Makefile | 2 + lib/librte_ether/rte_ethdev.c | 117 ------------------ lib/librte_ether/rte_ethdev.h | 105 +--------------- lib/librte_ether/rte_ethdev_pci.h | 191 ++++++++++++++++++++++++++++++ lib/librte_ether/rte_ethdev_vdev.h | 84 +++++++++++++ lib/librte_ether/rte_ether_version.map | 11 +- test/test/test_link_bonding_rssconf.c | 4 +- test/test/virtual_pmd.c | 12 +- 55 files changed, 1185 insertions(+), 966 deletions(-) delete mode 100644 drivers/net/null/rte_eth_null.h create mode 100644 lib/librte_ether/rte_ethdev_pci.h create mode 100644 lib/librte_ether/rte_ethdev_vdev.h
Signature · 1 line
2.1.4