platform/x86: hp-wmi: Driver refactoring and cleanups
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | platform/x86: hp-wmi: Cleanup local variable declarationsdrivers/ | +13 | 0 replies | |
| 2/9 | platform/x86: hp-wmi: Add bios_args initializerdrivers/ | +11 | 1 reply | |
| 3/9 | platform/x86: hp-wmi: Standardize enum usage for constantsdrivers/ | +64 | 2 replies | |
| 4/9 | platform/x86: hp-wmi: Refactor redundant HPWMI_READ functionsdrivers/ | +24 | 0 replies | |
| 5/9 | platform/x86: hp-wmi: Cleanup wireless get_(hw|sw)state functionsdrivers/ | +8 | 0 replies | |
| 6/9 | platform/x86: hp-wmi: Refactor dock and tablet state fetchersdrivers/ | +14 | 0 replies | |
| 7/9 | platform/x86: hp-wmi: Use DEVICE_ATTR_(RO|RW) helper macrosdrivers/ | +18 | 0 replies | |
| 8/9 | platform/x86: hp-wmi: Do not shadow errors in sysfs show functionsdrivers/ | +6 | 0 replies | |
| 9/9 | platform/x86: hp-wmi: Cleanup exit pathsdrivers/ | +33 | 0 replies |
Reviews trailers per patch
1 of 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Andy Shevchenko | Carlo Caione |
|---|---|---|
| Series | R-b | T-b |
| 1/9 | ||
| 2/9 | ||
| 3/9 | R-b R-b | T-b |
| 4/9 | ||
| 5/9 | ||
| 6/9 | ||
| 7/9 | ||
| 8/9 | ||
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v1 0/9] platform/x86: hp-wmi: Driver refactoring and cleanups
From: "Darren Hart (VMware)" <[email protected]>
This series factors out some redundant code, cleans up a number of style issues, modernizes the sysfs usage, and cleans up the return paths. All told, the driver is reduced in size by 37 lines (3.6%).
I do not have an HP laptop, so I'm hoping Carlo can help out with some testing. In particular we need to verify that hotkeys and sysfs continue to work as before.
This series is also available here for convenience:git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git hp-wmi
Darren Hart (VMware) (9):
platform/x86: hp-wmi: Cleanup local variable declarations platform/x86: hp-wmi: Add bios_args initializer platform/x86: hp-wmi: Standardize enum usage for constants platform/x86: hp-wmi: Refactor redundant HPWMI_READ functions platform/x86: hp-wmi: Cleanup wireless get_(hw|sw)state functions platform/x86: hp-wmi: Refactor dock and tablet state fetchers platform/x86: hp-wmi: Use DEVICE_ATTR_(RO|RW) helper macros platform/x86: hp-wmi: Do not shadow errors in sysfs show functions platform/x86: hp-wmi: Cleanup exit paths
drivers/platform/x86/hp-wmi.c | 385 +++++++++++++++++++----------------------- 1 file changed, 174 insertions(+), 211 deletions(-)
Signature · 1 line
2.9.3