Skip to content

nvme APST fixes/improvements for 4.11

Andy Lutomirski linux-nvme lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5nvme: Fix APST commentdrivers/nvme/host/core.c+1 -10 replies
2/5nvme: Display raw APST configuration via DYNAMIC_DEBUGdrivers/nvme/host/core.c+16 -00 replies
3/5nvme: Add nvme_core.force_apst to ignore the NO_APST quirkdrivers/nvme/host/core.c+14 -10 replies
4/5nvme: Adjust the Samsung APST quirkdrivers/nvme/host/core.c drivers/nvme/host/nvme.h drivers/nvme/host/pci.c+43 -113 replies
5/5nvme: Quirk APST off on "THNSF5256GPUK TOSHIBA"drivers/nvme/host/core.c+9 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] nvme APST fixes/improvements for 4.11

Sorry for waiting so long for this. I was waiting for feedback from Samsung, but they haven't root-caused the issue yet, and I should have just done this from the beginning.

This series makes APST more debuggable and updates the quirk list. The quirks I'm aware of are:

- Samsung 950 series SSDs in Dell XPS 15 9550 and Precision 5510 laptops (which are essentially the same laptop) can lose their PCIe link if they're allowed to use the deepest APST state. Samsung engineers have an affected system and are working on it. The same exact SSDs in other machines (even an XPS 13) seem to work fine.

- One Toshiba device malfunctions if APST is used at all.

One thing that improves my confidence that there aren't too many more problems with APST is that Ubuntu has backported APST to Zesty, so it's already gotten a bit of testing in a widely used (if very new) release.

Andy Lutomirski (5):
nvme: Fix APST comment
nvme: Display raw APST configuration via DYNAMIC_DEBUG
nvme: Add nvme_core.force_apst to ignore the NO_APST quirk
nvme: Adjust the Samsung APST quirk
nvme: Quirk APST off on "THNSF5256GPUK TOSHIBA"

 drivers/nvme/host/core.c | 61 ++++++++++++++++++++++++++++++++++++++++--------
 drivers/nvme/host/nvme.h |  5 ++++
 drivers/nvme/host/pci.c  | 26 ++++++++++++++++++++-
 3 files changed, 81 insertions(+), 11 deletions(-)
Signature · 1 line
2.9.3