Fixes for exported headers
Status from this message: Applied, thanks
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest14 patches 6 repliesApplied
- v213 patches 13 repliesSuperseded
- v113 patches 4 repliesSuperseded
Changes in v3 from the cover letter
- Reverted regression introduced in v2 related to RTE_PMD_DEBUG_TRACE() and RTE_LIBRTE_EVENTDEV_DEBUG.
- Addressed original issue with RTE_PMD_DEBUG_TRACE() in a new separate commit.
- Fixed remaining regression on the kernel side of avp.
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | crypto/scheduler: fix missing includesdrivers/ drivers/ | +2 | 0 replies | |
| 2/14 | eventdev: fix errors with strict compilation flagslib/ lib/ | +10 | 1 reply | |
| 3/14 | latency: fix missing includes in exported headerlib/ | +2 | 0 replies | |
| 4/14 | net: fix missing include in exported headerlib/ | +2 | 0 replies | |
| 5/14 | vhost: fix errors with strict compilation flagsdevtools/ lib/ | +16 | 0 replies | |
| 6/14 | mbuf: fix missing includes in exported headerlib/ | +3 | 0 replies | |
| 7/14 | net/avp: fix errors in exported headersdrivers/ drivers/ | +29 | 0 replies | |
| 8/14 | bitrate: fix errors in exported headerlib/ | +10 | 1 reply | |
| 9/14 | efd: fix missing include in exported headerlib/ | +2 | 1 reply | |
| 10/14 | metrics: fix errors in exported headerlib/ | +10 | 1 reply | |
| 11/14 | ethdev: fix C++ errors in flow APIlib/ | +26 | 0 replies | |
| 12/14 | ethdev: fix C++ errors in flow API (MPLS, GRE)lib/ | +4 | 0 replies | |
| 13/14 | ethdev: fix incomplete items in flow APIapp/ doc/ doc/ +1 more | +101 | 1 reply | |
| 14/14 | eal: fix debug macro redefinitionlib/ lib/ lib/ +1 more | +14 | 0 replies |
Reviews trailers per patch
12 of 14 patches have a Reviewed-by or Acked-by.
| Patch | Fan Zhang | Jasvinder Singh | Yuanhan Liu | Maxime Coquelin | Olivier Matz | Allain Legacy | Shahaf Shuler | Beilei Xing | Jerin Jacob | Remy Horton | Pablo de Lara | Wenzhuo Lu |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1/14 | A-b | |||||||||||
| 2/14 | A-b | |||||||||||
| 3/14 | ||||||||||||
| 4/14 | A-b | |||||||||||
| 5/14 | A-b | A-b | ||||||||||
| 6/14 | A-b | |||||||||||
| 7/14 | A-b | |||||||||||
| 8/14 | A-b | |||||||||||
| 9/14 | A-b | |||||||||||
| 10/14 | A-b | |||||||||||
| 11/14 | A-b | |||||||||||
| 12/14 | A-b | A-b | ||||||||||
| 13/14 | A-b | |||||||||||
| 14/14 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 12 reviewers.
Cover letter [PATCH v3 00/14] Fixes for exported headers
This series addresses the remaining issues seen by check-includes.sh in exported headers. Most of them may cause compilation errors in user applications:
- Dependencies on missing includes.
- Non-standard C/C++ constructs usage without associated safeties.
- Missing C++ awareness blocks.
It also addresses the incomplete implementation of E-Tag and NVGRE flow API pattern items.
Changes in v2:
- Fixed (still) incomplete E-tag and NVGRE flow API documentation.
- Renamed E-Tag item parameter "ecid_b" to "grp_ecid_b" in testpmd, to reflect that both fields are set at once.
- Fixed remaining compilation issue with RTE_LIBRTE_EVENTDEV_DEBUG.
- Fixed avp include to avoid kernel module compilation issue pointed out by Allain.
Changes in v3:
- Reverted regression introduced in v2 related to RTE_PMD_DEBUG_TRACE() and RTE_LIBRTE_EVENTDEV_DEBUG.
- Addressed original issue with RTE_PMD_DEBUG_TRACE() in a new separate commit.
- Fixed remaining regression on the kernel side of avp.
Adrien Mazarguil (14):
crypto/scheduler: fix missing includes
eventdev: fix errors with strict compilation flags
latency: fix missing includes in exported header
net: fix missing include in exported header
vhost: fix errors with strict compilation flags
mbuf: fix missing includes in exported header net/avp: fix errors in exported headers
bitrate: fix errors in exported header
efd: fix missing include in exported header
metrics: fix errors in exported header
ethdev: fix C++ errors in flow API
ethdev: fix C++ errors in flow API (MPLS, GRE)
ethdev: fix incomplete items in flow API
eal: fix debug macro redefinition
app/test-pmd/cmdline_flow.c | 46 ++++++++++++++++++ devtools/check-includes.sh | 4 +- doc/guides/prog_guide/rte_flow.rst | 26 ++++++++++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 +++ .../crypto/scheduler/rte_cryptodev_scheduler.h | 1 + .../rte_cryptodev_scheduler_operations.h | 1 + drivers/net/avp/rte_avp_common.h | 18 ++++++- drivers/net/avp/rte_avp_fifo.h | 12 +++++ lib/librte_bitratestats/rte_bitrate.h | 10 ++++ lib/librte_cryptodev/rte_cryptodev_pmd.h | 8 --- lib/librte_eal/common/include/rte_dev.h | 14 ++++++ lib/librte_efd/rte_efd.h | 2 + lib/librte_ether/rte_ethdev.h | 9 ---- lib/librte_ether/rte_flow.h | 51 ++++++++++++++++++++ lib/librte_eventdev/rte_eventdev.h | 3 +- lib/librte_eventdev/rte_eventdev_pmd.h | 23 ++++----- lib/librte_latencystats/rte_latencystats.h | 2 + lib/librte_mbuf/rte_mbuf_ptype.h | 3 ++ lib/librte_metrics/rte_metrics.h | 10 ++++ lib/librte_net/rte_net_crc.h | 2 + lib/librte_vhost/rte_vhost.h | 16 ++++-- 21 files changed, 231 insertions(+), 38 deletions(-)
Signature · 1 line
2.1.4