Introduce new mode validation callbacks
Status from this message: Queued to drm-misc after adding static again^ and fixing up 80 line warning.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest10 patches 28 repliesApplied
- v410 patches 8 repliesSuperseded
- v36 patches 12 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 8 patches | 30 replies | Superseded | |
| v1 | 5 patches | 10 replies | Superseded |
Patches in v5 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | drm: Add drm_{crtc/encoder/connector}_mode_valid()drivers/ drivers/ | +51 | 2 replies | |
| 2/10 | drm: Introduce drm_bridge_mode_valid()drivers/ include/ | +35 | 2 replies | |
| 3/10 | drm: Use new mode_valid() helpers in connector probe helperdrivers/ | +63 | 1 reply | |
| 4/10 | drm: Use mode_valid() in atomic modesetdrivers/ | +73 | 2 replies | |
| 5/10 | drm: arcpgu: Use crtc->mode_valid() callbackdrivers/ | +14 | 3 replies | |
| 6/10 | drm/bridge: analogix-anx78xx: Use bridge->mode_valid() callbackdrivers/ | +6 | 3 replies | |
| 7/10 | drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callbackdrivers/ drivers/ drivers/ +2 more | +17 | 4 replies | |
| 8/10 | drm/arm: malidp: Use crtc->mode_valid() callbackdrivers/ | +5 | 6 replies | |
| 9/10 | drm/atmel-hlcdc: Use crtc->mode_valid() callbackdrivers/ | +4 | 2 replies | |
| 10/10 | drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacksdrivers/ drivers/ | +12 | 3 replies |
Reviews trailers per patch
All 10 patches have a Reviewed-by or Acked-by.
| Patch | Daniel Vetter | Andrzej Hajda | Alexey Brodkin | Neil Armstrong | Archit Taneja | Liviu Dudau | Philipp Zabel |
|---|---|---|---|---|---|---|---|
| 1/10 | R-b | R-b | R-b | ||||
| 2/10 | R-b | R-b | R-b | ||||
| 3/10 | R-b | R-b | |||||
| 4/10 | R-b | R-b | R-b | ||||
| 5/10 | R-b | R-b | |||||
| 6/10 | R-b | R-b | |||||
| 7/10 | A-b T-b | A-b | |||||
| 8/10 | R-b | A-b | |||||
| 9/10 | R-b | ||||||
| 10/10 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.
Cover letter [PATCH v5 00/10] Introduce new mode validation callbacks
NOTE: In this version I just did a rebase onto today's drm-next and added the tags we've collected plus the changelog plus the missing maintainers that I forgot to cc in previous version :/
This series is a follow up from the discussion at [1]. We start by introducing crtc->mode_valid(), encoder->mode_valid() and bridge->mode_valid() callbacks which will be used in followup patches and also by cleaning the documentation a little bit. This patch is available at [2] and the series depends on it.
We proceed by introducing new helpers to call this new callbacks at 1/10.
At 2/10 a helper function is introduced that calls all mode_valid() from a set of bridges.
Next, at 3/10 we modify the connector probe helper so that only modes which are supported by a given bridge+encoder+crtc combination are probbed.
At 4/10 we call all the mode_valid() callbacks for a given pipeline, except the connector->mode_valid one, so that the mode is validated. This is done before calling mode_fixup().
Finally, from 5/10 to 10/10 we use the new callbacks in drivers that can implement it.
[1] https://patchwork.kernel.org/patch/9702233/
[2] https://lists.freedesktop.org/archives/dri-devel/2017-May/141761.html
Jose Abreu (10):
drm: Add drm_{crtc/encoder/connector}_mode_valid()
drm: Introduce drm_bridge_mode_valid()
drm: Use new mode_valid() helpers in connector probe helper
drm: Use mode_valid() in atomic modeset
drm: arcpgu: Use crtc->mode_valid() callback
drm/bridge: analogix-anx78xx: Use bridge->mode_valid() callback drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback drm/arm: malidp: Use crtc->mode_valid() callback drm/atmel-hlcdc: Use crtc->mode_valid() callback
drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacks
drivers/gpu/drm/arc/arcpgu_crtc.c | 29 ++++--- drivers/gpu/drm/arm/malidp_crtc.c | 11 ++- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 9 +-- drivers/gpu/drm/bridge/analogix-anx78xx.c | 13 ++- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 40 +++------- drivers/gpu/drm/drm_atomic_helper.c | 76 +++++++++++++++++- drivers/gpu/drm/drm_bridge.c | 33 ++++++++ drivers/gpu/drm/drm_crtc_helper_internal.h | 13 +++ drivers/gpu/drm/drm_probe_helper.c | 105 ++++++++++++++++++++++++- drivers/gpu/drm/imx/dw_hdmi-imx.c | 4 +- drivers/gpu/drm/meson/meson_dw_hdmi.c | 2 +- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 +- drivers/gpu/drm/vc4/vc4_crtc.c | 13 ++- drivers/gpu/drm/vc4/vc4_dpi.c | 13 ++- include/drm/bridge/dw_hdmi.h | 2 +- include/drm/drm_bridge.h | 2 + 16 files changed, 280 insertions(+), 87 deletions(-)
Signature · 1 line
1.9.1