Skip to content

x86 TLB flush cleanups, moving toward PCID support

Andy Lutomirski kvm linux-mm 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest8 patches 11 repliesIn review
  2. v38 patches 6 repliesApplied
  3. v211 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC10 patches21 repliesSuperseded

Changes in v4 from the cover letter

- Fix leave_mm() wrt intel_idle.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8x86/mm: Pass flush_tlb_info to flush_tlb_others() etcarch/x86/include/asm/paravirt.h arch/x86/include/asm/paravirt_types.h arch/x86/include/asm/tlbflush.h +4 more+59 -641 reply
2/8x86/mm: Change the leave_mm() condition for local TLB flushesarch/x86/mm/tlb.c+1 -11 reply
3/8x86/mm: Refactor flush_tlb_mm_range() to merge local and remote casesarch/x86/include/asm/tlbflush.h arch/x86/mm/tlb.c+48 -665 replies
4/8x86/mm: Use new merged flush logic in arch_tlbbatch_flush()arch/x86/mm/tlb.c+2 -60 replies
5/8x86/mm: Remove the UP tlbflush code; always use the formerly SMP codearch/x86/Kconfig arch/x86/include/asm/hardirq.h arch/x86/include/asm/mmu.h +5 more+5 -1040 replies
6/8x86/mm: Rework lazy TLB to track the actual loaded mmarch/x86/events/core.c arch/x86/include/asm/tlbflush.h arch/x86/kernel/ldt.c +3 more+147 -1440 replies
7/8x86/mm: Be more consistent wrt PAGE_SHIFT vs PAGE_SIZE in tlb flush codearch/x86/mm/tlb.c+2 -30 replies
8/8x86,kvm: Teach KVM's VMX code that CR3 isn't a constantarch/x86/include/asm/mmu_context.h arch/x86/kvm/vmx.c+37 -32 replies

Reviews trailers per patch

2 of 8 patches have a Reviewed-by or Acked-by.

PatchNadav AmitRik van Riel
1/8A-b
2/8A-b
3/8
4/8
5/8
6/8
7/8Requested-by
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/8] x86 TLB flush cleanups, moving toward PCID support

As I've been working on polishing my PCID code, a major problem I've encountered is that there are too many x86 TLB flushing code paths and that they have too many inconsequential differences. The result was that earlier versions of the PCID code were a colossal mess and very difficult to understand.

This series goes a long way toward cleaning up the mess. With all the patches applied, there is a single function that contains the meat of the code to flush the TLB on a given CPU, and all the tlb flushing APIs call it for both local and remote CPUs.

This series should only adversely affect the kernel in a couple of minor ways:

- It makes smp_mb() unconditional when flushing TLBs. We used to use the TLB flush itself to mostly avoid smp_mb() on the initiating CPU.

- On UP kernels, we lose the dubious optimization of inlining nerfed variants of all the TLB flush APIs. This bloats the kernel a tiny bit, although it should increase performance, since the SMP versions were better.

Patch 8 in here is a little bit off topic. It's a cleanup that's also needed before PCID can go in, but it's not directly about TLB flushing.

NB: The kbuild bot hasn't tested this yet, but it's only slightly different from v3, and I'm running it on my laptop where I'm typing this right now.

Changes from v3:
- Fix leave_mm() wrt intel_idle.

Changes from v1:
- Rebased onto tip:x86/mm to pick up UV and Xen changes.
- Drop the patches that Ingo already applied.

Changes from RFC:
- Fixed missing call to arch_tlbbatch_flush().
- "Be more consistent wrt PAGE_SHIFT vs PAGE_SIZE in tlb flush code" is new
- Misc typos fixed.
- Actually compiles when UV is enabled.

Andy Lutomirski (8):
x86/mm: Pass flush_tlb_info to flush_tlb_others() etc x86/mm: Change the leave_mm() condition for local TLB flushes x86/mm: Refactor flush_tlb_mm_range() to merge local and remote cases x86/mm: Use new merged flush logic in arch_tlbbatch_flush() x86/mm: Remove the UP tlbflush code; always use the formerly SMP code x86/mm: Rework lazy TLB to track the actual loaded mm x86/mm: Be more consistent wrt PAGE_SHIFT vs PAGE_SIZE in tlb flush
code
x86,kvm: Teach KVM's VMX code that CR3 isn't a constant

 arch/x86/Kconfig                      |   2 +-
 arch/x86/events/core.c                |   3 +-
 arch/x86/include/asm/hardirq.h        |   2 +-
 arch/x86/include/asm/mmu.h            |   6 -
 arch/x86/include/asm/mmu_context.h    |  21 +-
 arch/x86/include/asm/paravirt.h       |   6 +-
 arch/x86/include/asm/paravirt_types.h |   5 +-
 arch/x86/include/asm/tlbbatch.h       |   2 -
 arch/x86/include/asm/tlbflush.h       | 104 ++-------
 arch/x86/include/asm/uv/uv.h          |   9 +-
 arch/x86/kernel/ldt.c                 |   7 +-
 arch/x86/kvm/vmx.c                    |  21 +-
 arch/x86/mm/init.c                    |   4 +-
 arch/x86/mm/tlb.c                     | 397 ++++++++++++++++------------------
 arch/x86/platform/uv/tlb_uv.c         |  10 +-
 arch/x86/xen/mmu_pv.c                 |  61 +++---
 16 files changed, 285 insertions(+), 375 deletions(-)
Signature · 7 lines
2.9.3

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>