Skip to content

#10073: generic EFI for wic

Ed Bartosh openembedded-core 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 0 repliesNew
  2. v47 patches 5 repliesSuperseded
  3. v35 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches1 replySuperseded
v14 patches0 repliesSuperseded

Changes in v5 from the cover letter

- yet another fix for scheduling of do_prepare_wic_build: explicitly added dependencies do_prepare_wic_build -> EFI_PROVIDER:do_deploy in efi provider classes

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6efi: add efi_bootfs_populate APImeta/classes/grub-efi.bbclass meta/classes/systemd-boot.bbclass+12 -00 replies
2/6image_types_wic: add do_populate_bootfs taskmeta/classes/image_types_wic.bbclass+37 -00 replies
3/6image_types_wic: merged 2 tasksmeta/classes/image_types_wic.bbclass+28 -250 replies
4/6grub-efi: fixed default value of GRUB_ROOTmeta/classes/grub-efi.bbclass+4 -40 replies
5/6image_types_wic: schedule prepare_wic_build correctlymeta/classes/grub-efi.bbclass meta/classes/image_types_wic.bbclass meta/classes/systemd-boot.bbclass+15 -130 replies
6/6oe-selftest: add wic tests for generic EFImeta-selftest/wic/test_generic_efi.wks.in meta/lib/oeqa/selftest/cases/wic.py+45 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/6] #10073: generic EFI for wic

Hi,

This patchset is an implementation of generic EFI approach for wic images.

Instead of introducing yet another wic plugin it uses existing APIs from EFI_PROVIDER classes to populate ${WORKDIR}/bootfs directory with EFI artifacts and bootloader configuration. This directory can be used by wic rootfs plugin to put into boot partition of the image.

Example kickstart file and 2 test cases were added to wic test suite to better illustrate the approach.

I personally like this approach much better than duplicating oe image creation functionality in wic plugins. This way we can have the code in one place and bootloaders can be configured the same way for oe and wic images.

Changes in v2:
- added patch: fixed default value of GRUB_ROOT
- fixed typo in commit message: timage_types_wic > image_types_wic

Changes in v3:
- scheduled do_prepare_wic_build as earlier as possible

Changes in v4:
- fixed build on platforms that don't support EFI
- fixed non-gpl3 build
- fixed build failure in systemd-boot code caused by rescheduled do_populate_bootfs to run earlier

Changes in v5:
- yet another fix for scheduling of do_prepare_wic_build: explicitly added dependencies do_prepare_wic_build -> EFI_PROVIDER:do_deploy in efi provider classes

NOTE: to make this working on meta-intel we'll need to add dependency
do_prepare_wic_build -> "${MLPREFIX}rmc-db:do_deploy" I'll send patch for this as soon as this patchset is accepted.

The following changes since commit 6964efddd31c479386d1643c1025bc102710392f:

bitbake: cooker: ensure graceful exit after exception during BuildCompleted handler (2017-06-14 14:54:25 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ed/wip
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wip

Ed Bartosh (6):
efi: add efi_bootfs_populate API
image_types_wic: add do_populate_bootfs task
image_types_wic: merged 2 tasks
grub-efi: fixed default value of GRUB_ROOT
image_types_wic: schedule prepare_wic_build correctly
oe-selftest: add wic tests for generic EFI

 meta-selftest/wic/test_generic_efi.wks.in |  9 ++++
 meta/classes/grub-efi.bbclass             | 15 ++++--
 meta/classes/image_types_wic.bbclass      | 84 +++++++++++++++++++++++--------
 meta/classes/systemd-boot.bbclass         |  7 +++
 meta/lib/oeqa/selftest/cases/wic.py       | 36 +++++++++++++
 5 files changed, 125 insertions(+), 26 deletions(-)
 create mode 100644 meta-selftest/wic/test_generic_efi.wks.in
Signature · 1 line
2.1.4