Skip to content

Reduce the number of I/O ops when doing COW

Alberto Garcia qemu-devel 4 versions – Applied

Status from this message: Thanks, applied to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 1 replyApplied
  2. v37 patches 0 repliesSuperseded
  3. v27 patches 13 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v17 patches24 repliesSuperseded

Changes in v4 from the cover letter

- Patch 6: Initialize the QEMUIOVector with only 1 iovecs [Kevin]
- Patch 7: Initialize the QEMUIOVector with 2 + m->data_qiov->niov [Kevin]
- Patch 7: Rename can_merge_cow() to merge_cow() [Kevin]

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/7qcow2: Remove unused Error variable in do_perform_cow()block/qcow2-cluster.c+1 -30 replies
2/7qcow2: Use unsigned int for both members of Qcow2COWRegionblock/qcow2-cluster.c block/qcow2.h+4 -40 replies
3/7qcow2: Make perform_cow() call do_perform_cow() twiceblock/qcow2-cluster.c+23 -150 replies
4/7qcow2: Split do_perform_cow() into _read(), _encrypt() and _write()block/qcow2-cluster.c+87 -300 replies
5/7qcow2: Allow reading both COW regions with only one requestblock/qcow2-cluster.c+38 -130 replies
6/7qcow2: Pass a QEMUIOVector to do_perform_cow_{read, write}()block/qcow2-cluster.c+24 -270 replies
7/7qcow2: Merge the writing of the COW regions with the guest datablock/qcow2-cluster.c block/qcow2.c block/qcow2.h+91 -200 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchEric BlakeKevin Wolf
1/7R-b R-b
2/7R-b R-b
3/7R-b R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH v4 0/7] Reduce the number of I/O ops when doing COW

Hi all,

here's a patch series that rewrites the copy-on-write code in the qcow2 driver to reduce the number of I/O operations.

This is version v4, please refer to the original e-mail for a complete description:

https://lists.gnu.org/archive/html/qemu-block/2017-05/msg00882.html

Regards,

Berto

v4:
- Patch 6: Initialize the QEMUIOVector with only 1 iovecs [Kevin]
- Patch 7: Initialize the QEMUIOVector with 2 + m->data_qiov->niov [Kevin]
- Patch 7: Rename can_merge_cow() to merge_cow() [Kevin]

v3: https://lists.gnu.org/archive/html/qemu-block/2017-06/msg00472.html
- Patch 4: Over-allocate the read buffer in perform_cow() so both COW sectors are optimally aligned [Eric]

v2: https://lists.gnu.org/archive/html/qemu-block/2017-06/msg00227.html
- Patch 1: Update commit message [Eric]
- Patch 7: Make sure that the number of iovs does not exceed IOV_MAX [Anton]
- Patch 7: Don't add zero-length buffers to the qiov in perform_cow()

v1: https://lists.gnu.org/archive/html/qemu-block/2017-05/msg00882.html
- Initial version

Output of git-backport-diff against v3:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/7:[----] [--] 'qcow2: Remove unused Error variable in do_perform_cow()' 002/7:[----] [--] 'qcow2: Use unsigned int for both members of Qcow2COWRegion' 003/7:[----] [--] 'qcow2: Make perform_cow() call do_perform_cow() twice' 004/7:[----] [--] 'qcow2: Split do_perform_cow() into _read(), _encrypt() and _write()' 005/7:[----] [--] 'qcow2: Allow reading both COW regions with only one request' 006/7:[0002] [FC] 'qcow2: Pass a QEMUIOVector to do_perform_cow_{read,write}()' 007/7:[0008] [FC] 'qcow2: Merge the writing of the COW regions with the guest data'

Alberto Garcia (7):
qcow2: Remove unused Error variable in do_perform_cow()
qcow2: Use unsigned int for both members of Qcow2COWRegion
qcow2: Make perform_cow() call do_perform_cow() twice
qcow2: Split do_perform_cow() into _read(), _encrypt() and _write()
qcow2: Allow reading both COW regions with only one request
qcow2: Pass a QEMUIOVector to do_perform_cow_{read,write}()
qcow2: Merge the writing of the COW regions with the guest data

 block/qcow2-cluster.c | 201 ++++++++++++++++++++++++++++++++++++++------------
 block/qcow2.c         |  64 +++++++++++++---
 block/qcow2.h         |  11 ++-
 3 files changed, 216 insertions(+), 60 deletions(-)
Signature · 1 line
2.11.0