Skip to content

ARM: imx6ul-14x14-evk: Fix suspend over nfs by phy

Leonard Crestez linux-arm-kernel lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesIn review
  2. v12 patches 8 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ARM: dts: imx6ul-14x14-evk: Add ksz8081 phy propertiesarch/arm/boot/dts/imx6ul-14x14-evk.dts+6 -01 reply
2/2net: phy: micrel: Restore led_mode and clk_sel on resumedrivers/net/phy/micrel.c+28 -141 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchFabio EstevamFlorian Fainelli
1/2R-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] ARM: imx6ul-14x14-evk: Fix suspend over nfs by phy

Right now attempting doing suspend/resume while root is mounted over NFS hangs on imx6ul-14x14-evk. This is happening because ksz8081 phy fixups are lost on resume.

Fix this by using equivalent devicetree properties instead of a phy fixup and handling those properties on resume in the micrel driver.

In theory it might now be possible to remove the phy fixup from mach-imx6ul entirely but it is possible that this would break other imx6ul boards which use the same phy. The solution would be to patch their dts but it's not clear how to identify affected boards.

This code is shared with imx6ull-14x14-evk but 6ull suspend needs an unrelated patch: https://lkml.org/lkml/2017/5/30/584

This is something of a corner case so there is no CC: stable.

Changes since v1: https://lkml.org/lkml/2017/5/30/672
* Split a kszphy_config_reset function for stuff shared between
config_init and resume. Calling config_init directly could be an option but on some HW variants it does extra stuff like parsing devicetree options. That would not be appropriate for resume code.

Leonard Crestez (2):
ARM: dts: imx6ul-14x14-evk: Add ksz8081 phy properties
net: phy: micrel: Restore led_mode and clk_sel on resume

 arch/arm/boot/dts/imx6ul-14x14-evk.dts |  6 +++++
 drivers/net/phy/micrel.c               | 42 ++++++++++++++++++++++------------
 2 files changed, 34 insertions(+), 14 deletions(-)
Signature · 1 line
2.7.4