Skip to content

Improve error reporting

Mao Zhongyi qemu-devel 8 versions – Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest4 patches 1 replyApplied
  2. v8 posting 2/24 patches 4 repliesSuperseded
  3. v8 posting 1/24 patches 3 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v74 patches5 repliesSuperseded
v64 patches12 repliesSuperseded
v54 patches8 repliesSuperseded
v44 patches5 repliesSuperseded
v34 patches2 repliesSuperseded

Changes in v9 from the cover letter

* -rebase on upstream
-fix the commit message of patch04

Patches in v9 Applied

#Subject and filesSizeRepliesApplied
1/4net/socket: Don't treat odd socket type as SOCK_STREAMnet/socket.c+3 -30 replies
2/4net/socket: Convert several helper functions to Errornet/socket.c+50 -320 replies
3/4net/net: Convert parse_host_port() to Errorinclude/qemu/sockets.h net/net.c net/socket.c+34 -130 replies
4/4net/socket: Improve -net socket error reportingnet/socket.c+44 -480 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMarkus ArmbrusterDaniel P. Berrange
1/4R-b
2/4R-b R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [Qemu-devel] [PATCH v9 0/4] Improve error reporting

v9:
* -rebase on upstream
-fix the commit message of patch04

v8:
* PATCH 02 & 04
-resetting the error message for the user to read. [Markus Armbruster]
-fix the indentation and commit message. [Markus Armbruster]

v7:
* PATCH 01
-fix the error message. [Daniel P. Berrange]
-adjust the indentation problem. [Eric Blake]
* PATCH 03
-print a generic message when gethostbyname() failed in parse_host_port(),
drop the misleading ": unkonwn host" part. [Markus Armbruster]

v6:
* PATCH 02
-rename the subject
-drop the "qemu: error: " prefix.
-correct inappropriate error information settings.
* PATCH 03,04
-correct inappropriate error information settings. [Markus Armbruster]

v5:
* PATCH 01 make the commit message more exact about the actual function. [Markus Armbruster]
* PATCH 02, 03, 04 still retains the original function, but specific content and order of each patch has been adjusted substantially,
so that ensure each patch is a completed fix. [Markus Armbruster]

v4:
* PATCH 01 is redoing previous patch 1, replace the fprintf() with error_report() in the 'default' case of net_socket_fd_init() [Markus Armbruster]

v3:
* PATCH 01 is suggested by Markus and Daniel that removes the dubious 'default' case in the net_socket_fd_init(). Jason agreed.
* PATCH 02 is redoing previous patch 4.
* PATCH 04 is redoing previous patch 2, improves sort of error messages.

v2:
* PATCH 02 reworking of patch 2 following Markus's suggestion that convert error_report() in the function called by net_socket_*_init() to Error. Also add many error handling information.
* PATCH 03 net_socket_mcast_create(), net_socket_fd_init_dgram() and net_socket_fd_init() use the function such as fprintf, perror to report an error message. Convert it to Error.
* PATCH 04 parse_host_port() may fail without reporting an error. Now, fix it to set an error when it fails.

Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]

Mao Zhongyi (4):
net/socket: Don't treat odd socket type as SOCK_STREAM net/socket: Convert several helper functions to Error net/net: Convert parse_host_port() to Error net/socket: Improve -net socket error reporting

 include/qemu/sockets.h |   3 +-
 net/net.c              |  22 +++++--
 net/socket.c           | 156 ++++++++++++++++++++++++++++---------------------
 3 files changed, 108 insertions(+), 73 deletions(-)
Signature · 1 line
2.9.4

Read the cover letter in its thread