Skip to content

Fix a refname trimming problem in `log --bisect`

Michael Haggerty git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesIn review
  2. v12 patches 6 repliesSuperseded

Changes in v2 from the cover letter

* Added a test and tweaked the commit message of the first patch.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2for_each_bisect_ref(): don't trim refnamesrefs.c refs.h revision.c +1 more+31 -20 replies
2/2prefix_ref_iterator_advance(): relax the check of trim lengthrefs/iterator.c+4 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] Fix a refname trimming problem in `log --bisect`

This is v2 of these patches. Thanks to Peff and Junio for their feedback about v1 [1].

Changes since v1:

* Added a test and tweaked the commit message of the first patch.

As before, the second patch is optional. If it is omitted, it might flush out any other bugs like this one in client code. If it is included, regressions are less likely, but we won't learn about other misuses of the API. I have no strong opinion either way.

Michael

[1] http://public-inbox.org/git/[email protected]/

Michael Haggerty (2):
for_each_bisect_ref(): don't trim refnames prefix_ref_iterator_advance(): relax the check of trim length

 refs.c                     | 12 ++++++++++++
 refs.h                     |  5 ++++-
 refs/iterator.c            |  8 ++++----
 revision.c                 |  2 +-
 t/t6002-rev-list-bisect.sh | 14 ++++++++++++++
 5 files changed, 35 insertions(+), 6 deletions(-)
Signature · 1 line
2.11.0