Skip to content

Fix Rx interrupt support in mlx4 and mlx5

Adrien Mazarguil dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7net/mlx4: fix typos from prior commitdrivers/net/mlx4/mlx4.c+2 -20 replies
2/7net/mlx4: fix Rx interrupts with multiple portsdrivers/net/mlx4/mlx4.c drivers/net/mlx4/mlx4.h+10 -03 replies
3/7net/mlx4: fix Rx interrupts managementdrivers/net/mlx4/mlx4.c+72 -940 replies
4/7net/mlx5: fix misplaced Rx interrupts functionsdrivers/net/mlx5/mlx5_rxq.c drivers/net/mlx5/mlx5_rxtx.c drivers/net/mlx5/mlx5_rxtx.h+79 -790 replies
5/7net/mlx5: fix Rx interrupts support checksdrivers/net/mlx5/mlx5.c drivers/net/mlx5/mlx5_rxq.c drivers/net/mlx5/mlx5_rxtx.h+8 -120 replies
6/7net/mlx5: fix return value in Rx interrupts codedrivers/net/mlx5/mlx5_rxq.c+1 -10 replies
7/7net/mlx5: fix Rx interrupts managementdrivers/net/mlx5/mlx5_rxq.c drivers/net/mlx5/mlx5_rxtx.h drivers/net/mlx5/mlx5_trigger.c+78 -990 replies

Reviews trailers per patch

3 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNelio LaranjeiroMoti Haimovsky
SeriesA-b
1/7A-b A-b
2/7A-b
3/7A-b
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] Fix Rx interrupt support in mlx4 and mlx5

Several issues mainly related to error handling were found in both implementations as they share most of their Rx interrupts handling code.

Another problem with the mlx4 implementation is that it does not work properly with multiple ports adapters that share a common PCI device.

Adrien Mazarguil (7):
net/mlx4: fix typos from prior commit net/mlx4: fix Rx interrupts with multiple ports net/mlx4: fix Rx interrupts management net/mlx5: fix misplaced Rx interrupts functions net/mlx5: fix Rx interrupts support checks net/mlx5: fix return value in Rx interrupts code net/mlx5: fix Rx interrupts management

 drivers/net/mlx4/mlx4.c         | 179 ++++++++++++++++-------------------
 drivers/net/mlx4/mlx4.h         |   1 +
 drivers/net/mlx5/mlx5.c         |   2 +
 drivers/net/mlx5/mlx5_rxq.c     | 142 ++++++++++++++++++---------
 drivers/net/mlx5/mlx5_rxtx.c    |  73 --------------
 drivers/net/mlx5/mlx5_rxtx.h    |  12 +--
 drivers/net/mlx5/mlx5_trigger.c |  16 ++--
 7 files changed, 194 insertions(+), 231 deletions(-)
Signature · 1 line
2.1.4