Skip to content

net: sched: act_tunnel_key: UDP checksums

Jiri Benc netdev 1 version Applied

Status from this message: Applied both patches to net-next

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2net: sched: act_tunnel_key: request UDP checksum by defaultnet/sched/act_tunnel_key.c+2 -20 replies
1/2tc: m_tunnel_key: reformat the usage texttc/m_tunnel_key.c+7 -10 replies
2/2net: sched: act_tunnel_key: make UDP checksum configurableinclude/uapi/linux/tc_act/tc_tunnel_key.h net/sched/act_tunnel_key.c+13 -30 replies
2/2tc: m_tunnel_key: add csum/nocsum optionman/man8/tc-tunnel_key.8 tc/m_tunnel_key.c+38 -13 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/2] net: sched: act_tunnel_key: UDP checksums

Currently, the tunnel_key tc action does not set TUNNEL_CSUM, thus transmitting packets with zero UDP checksum. This is inconsistent with how we treat non-lwt UDP tunnels where the default is to fill in the UDP checksum. Non-zero UDP checksum is the better default anyway for various reasons previously discussed.

Make this configurable for the tunnel_key tc action with the default being non-zero checksum. Saves a lot of surprises especially with IPv6.

Signed-off-by Jiri Benc <[email protected]>

Jiri Benc (2):
net: sched: act_tunnel_key: request UDP checksum by default
net: sched: act_tunnel_key: make UDP checksum configurable

 include/uapi/linux/tc_act/tc_tunnel_key.h |  1 +
 net/sched/act_tunnel_key.c                | 15 ++++++++++++---
 2 files changed, 13 insertions(+), 3 deletions(-)
Signature · 1 line
1.8.3.1

Read the cover letter in its thread