g_NCR5380: PDMA fixes and cleanup
Status from this message: Applied to 4.14/scsi-queue. Thank you!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest6 patches 3 repliesApplied
- v66 patches 4 repliesSuperseded
- v56 patches 5 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 5 patches | 3 replies | Superseded | |
| v3 | 4 patches | 10 replies | Superseded | |
| v2 | 5 patches | 3 replies | Superseded | |
| v1 | 4 patches | 5 replies | Superseded |
Changes in v7 from the cover letter
- Fix residual calculation for the buffer timeout case.
- Iterate after sending final 128 bytes to check for buffer timeout.
- Don't log the residual value when it is known to be zero.
Patches in v7 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | g_NCR5380: Fix PDMA transfer sizedrivers/ | +3 | 0 replies | |
| 2/6 | g_NCR5380: End PDMA transfer correctly on target disconnectiondrivers/ | +31 | 0 replies | |
| 3/6 | g_NCR5380: Cleanup comments and whitespacedrivers/ | +28 | 0 replies | |
| 4/6 | g_NCR5380: Use unambiguous terminology for PDMA send and receivedrivers/ | +7 | 0 replies | |
| 5/6 | g_NCR5380: Re-work PDMA loopsdrivers/ | +102 | 0 replies | |
| 6/6 | g_NCR5380: Two DTC436 PDMA workaroundsdrivers/ | +11 | 0 replies |
Reviews trailers per patch
None of the 6 patches has a Reviewed-by or Acked-by.
| Patch | Ondrej Zary |
|---|---|
| Series | T-b |
| 1/6 | |
| 2/6 | |
| 3/6 | |
| 4/6 | |
| 5/6 | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v7 0/6] g_NCR5380: PDMA fixes and cleanup
Ondrej, would you please test this new series?
Changed since v1:
- PDMA transfer residual is calculated earlier.
- End of DMA flag check is now polled (if there is any residual).
Changed since v2:
- Bail out of transfer loops when Gated IRQ gets asserted.
- Make udelay conditional on board type.
- Drop sg_tablesize patch due to performance regression.
Changed since v3:
- Add Ondrej's workaround for corrupt WRITE commands on DTC boards.
- Reset the 53c400 logic after any short PDMA transfer.
- Don't fail the transfer if the 53c400 logic got a reset.
Changed since v4:
- Bail out of transfer loops when Gated IRQ gets asserted. (Again.)
- Always call wait_for_53c80_registers() at end of transfer.
- Drain chip buffers after PDMA receive is interrupted.
- Rework residual calculation.
- Add new patch to correct DMA terminology.
Changed since v5:
- Rework residual calculation to account for on-chip buffer swap.
- Attempt to retain the disconnect/IRQ detection in the DTC436 workaround.
- Move all DTC436 workarounds to final patch.
Changed since v6:
- Fix residual calculation for the buffer timeout case.
- Iterate after sending final 128 bytes to check for buffer timeout.
- Don't log the residual value when it is known to be zero.
Finn Thain (2):
g_NCR5380: Cleanup comments and whitespace
g_NCR5380: Use unambiguous terminology for PDMA send and receive
Ondrej Zary (4):
g_NCR5380: Fix PDMA transfer size
g_NCR5380: End PDMA transfer correctly on target disconnection
g_NCR5380: Re-work PDMA loops
g_NCR5380: Two DTC436 PDMA workarounds
drivers/scsi/g_NCR5380.c | 277 ++++++++++++++++++++++++++--------------------- 1 file changed, 155 insertions(+), 122 deletions(-)
Signature · 1 line
2.13.0