Skip to content

#11662 - wic should mount /boot

Ed Bartosh openembedded-core 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest7 patches 1 replyIn review
  2. v46 patches 0 repliesSuperseded
  3. v36 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches20 repliesSuperseded
v17 patches2 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7image_types.bbclass: ignore tar exit code 1meta/classes/image_types.bbclass+2 -10 replies
2/7wic: copy rootfs directory before changing fstabscripts/lib/wic/plugins/imager/direct.py+15 -90 replies
3/7wic: use absolute paths in rootfs pluginscripts/lib/wic/plugins/source/rootfs.py+2 -20 replies
4/7wic: rootfs: fix rootfs path reportingscripts/lib/wic/plugins/source/rootfs.py+4 -60 replies
5/7wic: rootfs: make copied rootfs uniquescripts/lib/wic/plugins/source/rootfs.py+1 -10 replies
6/7wic: add /boot mount point to fstab by defaultscripts/lib/wic/plugins/imager/direct.py+1 -10 replies
7/7oe-selftest: wic: fix test_quemumeta/lib/oeqa/selftest/cases/wic.py+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/7] #11662 - wic should mount /boot

Hi,

This patchset adds /boot to the /etc/fstab of root partition, making it mounted on boot. It also fixes reporting and testing issues caused by this change.

The patchset also fixes long standing bug: wic updated fstab inplace in rootfs directory. This causes other tasks working with rootfs directory to produce incorrect results or crash. This is fixed by hadlinking rootfs content to the temporary directory before updating fstab.

This approach caused do_image_tar to fail with the error "file changed as we read it" as hardlinking changes files ctime. In order to solve this we had to modify do_image_tar to ignore file changes.

Changes in v2: squashed patches by reviewer's request Changes in v3: unlink /etc/fstab in rootfs copy before updating it Changes in v4: used 'cp -a' instead of copyhardlinktree to avoid
do_image_tar failure due to changed ctime
Changes in v5: back to hardlinking. ignored tar exit code 1.

The following changes since commit b73f5e088a543775a2a94b60302f750edfffbd10:

wic-tools: add dependency to e2fsprogs-native (2017-07-27 16:07:26 +0300)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ed/wip
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wip

Ed Bartosh (7):
image_types.bbclass: ignore tar exit code 1
wic: copy rootfs directory before changing fstab
wic: use absolute paths in rootfs plugin
wic: rootfs: fix rootfs path reporting
wic: rootfs: make copied rootfs unique
wic: add /boot mount point to fstab by default
oe-selftest: wic: fix test_quemu

 meta/classes/image_types.bbclass         |  3 ++-
 meta/lib/oeqa/selftest/cases/wic.py      |  2 +-
 scripts/lib/wic/plugins/imager/direct.py | 26 ++++++++++++++++----------
 scripts/lib/wic/plugins/source/rootfs.py | 16 +++++++---------
 4 files changed, 26 insertions(+), 21 deletions(-)
Signature · 1 line
2.1.4