Skip to content

drivers: Boot Constraint core

Viresh Kumar linux-arm-kernel lkml 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest13 patches 6 repliesIn review
  2. v613 patches 5 repliesSuperseded
  3. v513 patches 7 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v412 patches28 repliesSuperseded
v38 patches14 repliesSuperseded
v2 RFC6 patches9 repliesSuperseded
v1 RFC5 patches31 repliesSuperseded

Changes in v7 from the cover letter

- s/drivers\/boot_constraint/drivers\/bootconstraint/ (Olof)
- Moved platform drivers to drivers/soc/<platform>/boot_constraint.c
- Changed year in file copyrights: s/2017/2018

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13of: platform: Add of_find_any_device_by_node()drivers/of/platform.c include/linux/of_platform.h+60 -00 replies
2/13of: platform: Make of_platform_bus_create() globaldrivers/of/platform.c include/linux/of_platform.h+15 -40 replies
3/13drivers: Add boot constraints coredrivers/Kconfig drivers/Makefile drivers/base/dd.c +5 more+343 -70 replies
4/13boot_constraint: Add support for supply constraintsdrivers/bootconstraint/Makefile drivers/bootconstraint/core.c drivers/bootconstraint/core.h +2 more+121 -20 replies
5/13boot_constraint: Add support for clk constraintsdrivers/bootconstraint/Makefile drivers/bootconstraint/clk.c drivers/bootconstraint/core.c +2 more+86 -10 replies
6/13boot_constraint: Add support for PM constraintsdrivers/bootconstraint/Makefile drivers/bootconstraint/core.c drivers/bootconstraint/core.h +2 more+31 -10 replies
7/13boot_constraint: Add debugfs supportdrivers/bootconstraint/clk.c drivers/bootconstraint/core.c drivers/bootconstraint/core.h +2 more+86 -20 replies
8/13boot_constraint: Manage deferrable constraintsdrivers/base/dd.c drivers/bootconstraint/Makefile drivers/bootconstraint/deferrable_dev.c +1 more+281 -10 replies
9/13boot_constraint: Add support for Hisilicon platformsdrivers/soc/Kconfig drivers/soc/Makefile drivers/soc/hisilicon/Kconfig +2 more+178 -00 replies
10/13boot_constraint: Add support for IMX platformdrivers/clk/imx/clk-imx25.c drivers/clk/imx/clk-imx27.c drivers/clk/imx/clk-imx31.c +11 more+135 -1400 replies
11/13boot_constraint: Add Qualcomm display controller constraintsdrivers/soc/qcom/Kconfig drivers/soc/qcom/Makefile drivers/soc/qcom/boot_constraint.c+131 -00 replies
12/13boot_constraint: Update MAINTAINERSMAINTAINERS+9 -00 replies
13/13boot_constraint: Add documentationDocumentation/driver-api/boot-constraint/constraints.rst Documentation/driver-api/boot-constraint/index.rst Documentation/driver-api/index.rst+103 -00 replies

Reviews trailers per patch

None of the 13 patches has a Reviewed-by or Acked-by.

PatchRajendra Nayak
1/13
2/13
3/13T-b
4/13T-b
5/13T-b
6/13T-b
7/13T-b
8/13T-b
9/13
10/13
11/13
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH V7 00/13] drivers: Boot Constraint core

Hi Greg,

The V7 version incorporates the organizational changes suggested by Olof earlier. Everything else is same otherwise.

I have tested the Hisilicon patches (again) on hikey 9660 board, IMX stuff was earlier tested by Sascha (Pengutronix) on i.MX6 and Qualcomm stuff was earlier tested by Rajendra (Qualcomm) on Dragonboard 410C (This required some more patches related to display driver which Rajendra should be sending separately later on).

Problem statement:

Some devices are powered ON by the bootloader before the bootloader handovers control to Linux. It maybe important for some of those devices to keep working until the time a Linux device driver probes the device and reconfigure its resources.

A typical example of that can be the LCD controller, which is used by the bootloaders to show image(s) while the platform is booting into Linux. The LCD controller can be using some resources, like clk, regulators, etc, that are shared between several devices. These shared resources should be configured to satisfy need of all the users. If another device's (X) driver gets probed before the LCD controller driver in this case, then it may end up disabling or reconfiguring these resources to ranges satisfying the current users (only device X) and that can make the LCD screen unstable.

Another case can be a debug serial port enabled from the bootloader.

Of course we can have more complex cases where the same resource is getting used by two devices while the kernel boots and the order in which devices get probed wouldn't matter as the other device will surely break then.

There are also cases where the resources may not be shared, but the kernel will disable them forcefully as no users may have appeared until a certain point in kernel boot. This makes sure that the resources stay enabled. A wide variety of constraints can be satisfied using the new framework.

Proposed solution:

This series introduces the concept of "boot-constraint", which are set by platform specific drivers (for now at least) at early init (like subsys_initcall) and the kernel will keep satisfying them until the time driver for such a device is probed (successfully or unsuccessfully). Once the driver is probed, the driver core removes the constraints set for the device. This series implements clk, regulator and PM domain constraints currently.

Pushed here:
git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/linux.git boot-constraint

More documentation on it can be found here:
https://lwn.net/Articles/747250/

V6->V7:
- s/drivers\/boot_constraint/drivers\/bootconstraint/ (Olof)
- Moved platform drivers to drivers/soc/<platform>/boot_constraint.c
- Changed year in file copyrights: s/2017/2018

V5->V6:
- Fix a build error reported by build bot for !CONFIG_OF_ADDRESS. This was already sent on 15th December.
- Rebased over latest driver-core-next.

V4->V5:
- SPDX Licence format used.
- arm,primecell stuff removed from boot constraint core and added a helper in OF core (which already handles amba and platform devices).
- Removed a bunch of BUG_ON(), pr_fmt(), comments.
- Changed directory and other names from boot_constraints/boot_constraint.
- Removed serial.o file and moved the code to hikey and imx files.
- Don't return error from dummy helper.
- Added documentation and corresponding kernel doc comments in the code.
- Updated MAINTAINERS.

V3->V4:
- Added support for imx, hikey and Qcom usecases.
- Enhanced boot constraints core to make drivers code easy and handle complex cases.
- Two new patches for OF included to provide APIs to boot constraint core.
- Removed the kernel parameter patch for now.
- Don't check return values of debugfs routines.
- Moved the boot constraints core from drivers/base/ to drivers/.

V2->V3:
- Removed DT support as we aren't sure about how to define the bindings yet.
- Added CLK and PM domain constraint types.
- A new directory is added for boot constraints, which will also contain platform specific drivers in future.
- Deferred devices are still supported, just that it wouldn't be called from generic code anymore but platform specific code.
- Tested on Qcom 410c dragonboard with display flash screen (Rajendra).
- Usual renaming/commit-log-updates/etc changes done.

V1->V2:
- Add support for setting constraints for devices created from DT.
- Allow handling deferred devices earlier then late_init.
- Remove 'default y' line from kconfig.
- Drop '=" after boot_constraints_disable kernel param.
- Dropped the dummy testing patch now.

--
viresh

*** BLURB HERE ***

Viresh Kumar (13):
of: platform: Add of_find_any_device_by_node()
of: platform: Make of_platform_bus_create() global
drivers: Add boot constraints core
boot_constraint: Add support for supply constraints
boot_constraint: Add support for clk constraints
boot_constraint: Add support for PM constraints
boot_constraint: Add debugfs support
boot_constraint: Manage deferrable constraints
boot_constraint: Add support for Hisilicon platforms
boot_constraint: Add support for IMX platform
boot_constraint: Add Qualcomm display controller constraints
boot_constraint: Update MAINTAINERS
boot_constraint: Add documentation

 .../driver-api/boot-constraint/constraints.rst     |  98 +++++++
 Documentation/driver-api/boot-constraint/index.rst |   4 +
 Documentation/driver-api/index.rst                 |   1 +
 MAINTAINERS                                        |   9 +
 drivers/Kconfig                                    |   2 +
 drivers/Makefile                                   |   1 +
 drivers/base/dd.c                                  |  32 ++-
 drivers/bootconstraint/Kconfig                     |   9 +
 drivers/bootconstraint/Makefile                    |   3 +
 drivers/bootconstraint/clk.c                       |  70 +++++
 drivers/bootconstraint/core.c                      | 290 +++++++++++++++++++++
 drivers/bootconstraint/core.h                      |  47 ++++
 drivers/bootconstraint/deferrable_dev.c            | 241 +++++++++++++++++
 drivers/bootconstraint/pm.c                        |  28 ++
 drivers/bootconstraint/supply.c                    | 104 ++++++++
 drivers/clk/imx/clk-imx25.c                        |  12 -
 drivers/clk/imx/clk-imx27.c                        |  13 -
 drivers/clk/imx/clk-imx31.c                        |  12 -
 drivers/clk/imx/clk-imx35.c                        |  10 -
 drivers/clk/imx/clk-imx51-imx53.c                  |  16 --
 drivers/clk/imx/clk-imx6q.c                        |   8 -
 drivers/clk/imx/clk-imx6sl.c                       |   8 -
 drivers/clk/imx/clk-imx6sx.c                       |   8 -
 drivers/clk/imx/clk-imx7d.c                        |  14 -
 drivers/clk/imx/clk.c                              |  38 ---
 drivers/clk/imx/clk.h                              |   1 -
 drivers/of/platform.c                              |  63 ++++-
 drivers/soc/Kconfig                                |   1 +
 drivers/soc/Makefile                               |   1 +
 drivers/soc/hisilicon/Kconfig                      |  15 ++
 drivers/soc/hisilicon/Makefile                     |   3 +
 drivers/soc/hisilicon/boot_constraint.c            | 158 +++++++++++
 drivers/soc/imx/Kconfig                            |   8 +
 drivers/soc/imx/Makefile                           |   1 +
 drivers/soc/imx/boot_constraint.c                  | 126 +++++++++
 drivers/soc/qcom/Kconfig                           |   8 +
 drivers/soc/qcom/Makefile                          |   1 +
 drivers/soc/qcom/boot_constraint.c                 | 122 +++++++++
 include/linux/boot_constraint.h                    | 121 +++++++++
 include/linux/of_platform.h                        |  16 ++
 40 files changed, 1572 insertions(+), 151 deletions(-)
 create mode 100644 Documentation/driver-api/boot-constraint/constraints.rst
 create mode 100644 Documentation/driver-api/boot-constraint/index.rst
 create mode 100644 drivers/bootconstraint/Kconfig
 create mode 100644 drivers/bootconstraint/Makefile
 create mode 100644 drivers/bootconstraint/clk.c
 create mode 100644 drivers/bootconstraint/core.c
 create mode 100644 drivers/bootconstraint/core.h
 create mode 100644 drivers/bootconstraint/deferrable_dev.c
 create mode 100644 drivers/bootconstraint/pm.c
 create mode 100644 drivers/bootconstraint/supply.c
 create mode 100644 drivers/soc/hisilicon/Kconfig
 create mode 100644 drivers/soc/hisilicon/Makefile
 create mode 100644 drivers/soc/hisilicon/boot_constraint.c
 create mode 100644 drivers/soc/imx/boot_constraint.c
 create mode 100644 drivers/soc/qcom/boot_constraint.c
 create mode 100644 include/linux/boot_constraint.h
Signature · 1 line
2.15.0.194.g9af6a3dea062