Skip to content

sctp: remove typedefs from structures part 1

Xin Long linux-sctp netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11sctp: remove the typedef sctp_sctphdr_tinclude/linux/sctp.h net/netfilter/ipset/ip_set_getport.c net/netfilter/ipvs/ip_vs_core.c +4 more+24 -250 replies
2/11sctp: remove the typedef sctp_chunkhdr_tinclude/linux/sctp.h include/net/sctp/sctp.h net/netfilter/ipvs/ip_vs_core.c +9 more+102 -1030 replies
3/11sctp: remove the typedef sctp_cid_tinclude/linux/sctp.h include/net/sctp/auth.h include/net/sctp/constants.h +4 more+16 -140 replies
4/11sctp: remove the typedef sctp_cid_action_tinclude/linux/sctp.h+2 -20 replies
5/11sctp: remove the typedef sctp_paramhdr_tinclude/linux/sctp.h include/net/sctp/sctp.h include/net/sctp/structs.h +7 more+79 -710 replies
6/11sctp: remove the typedef sctp_param_tinclude/linux/sctp.h include/net/sctp/sm.h net/sctp/sm_make_chunk.c+9 -110 replies
7/11sctp: remove the typedef sctp_param_action_tinclude/linux/sctp.h+2 -20 replies
8/11sctp: remove the typedef sctp_datahdr_tinclude/linux/sctp.h net/sctp/sm_statefuns.c+11 -80 replies
9/11sctp: remove the typedef sctp_data_chunk_tinclude/linux/sctp.h include/net/sctp/constants.h include/net/sctp/sm.h +3 more+10 -100 replies
10/11sctp: remove the typedef sctp_inithdr_tinclude/linux/sctp.h net/netfilter/nf_conntrack_proto_sctp.c net/sctp/sm_make_chunk.c +1 more+13 -130 replies
11/11sctp: remove the typedef sctp_init_chunk_tinclude/linux/sctp.h include/net/sctp/command.h include/net/sctp/structs.h +4 more+27 -270 replies

Reviews trailers per patch

None of the 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarcelo Ricardo Leitner
SeriesA-b
1/11
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 00/11] sctp: remove typedefs from structures part 1

As we know, typedef is suggested not to use in kernel, even checkpatch.pl also gives warnings about it. Now sctp is using it for many structures.

All this kind of typedef's using should be removed. As the 1st part, this patchset is to remove it for 11 basic structures in linux/sctp.h. It is also to fix some indents.

No any code's logic is changed in these patches, only cleaning up.

Xin Long (11):
sctp: remove the typedef sctp_sctphdr_t
sctp: remove the typedef sctp_chunkhdr_t
sctp: remove the typedef sctp_cid_t
sctp: remove the typedef sctp_cid_action_t
sctp: remove the typedef sctp_paramhdr_t
sctp: remove the typedef sctp_param_t
sctp: remove the typedef sctp_param_action_t
sctp: remove the typedef sctp_datahdr_t
sctp: remove the typedef sctp_data_chunk_t
sctp: remove the typedef sctp_inithdr_t
sctp: remove the typedef sctp_init_chunk_t

 include/linux/sctp.h                    | 118 ++++++++++++++--------------
 include/net/sctp/auth.h                 |   6 +-
 include/net/sctp/command.h              |   4 +-
 include/net/sctp/constants.h            |   6 +-
 include/net/sctp/sctp.h                 |   4 +-
 include/net/sctp/sm.h                   |  16 ++--
 include/net/sctp/structs.h              |   9 ++-
 net/netfilter/ipset/ip_set_getport.c    |   4 +-
 net/netfilter/ipvs/ip_vs_core.c         |  10 +--
 net/netfilter/ipvs/ip_vs_proto_sctp.c   |  21 +++--
 net/netfilter/nf_conntrack_proto_sctp.c |  33 ++++----
 net/netfilter/nf_nat_proto_sctp.c       |   2 +-
 net/netfilter/xt_sctp.c                 |  20 ++---
 net/sctp/associola.c                    |   6 +-
 net/sctp/auth.c                         |  28 ++++---
 net/sctp/endpointola.c                  |   7 +-
 net/sctp/input.c                        |  24 +++---
 net/sctp/inqueue.c                      |  15 ++--
 net/sctp/output.c                       |   4 +-
 net/sctp/sm_make_chunk.c                |  80 +++++++++----------
 net/sctp/sm_sideeffect.c                |   7 +-
 net/sctp/sm_statefuns.c                 | 132 ++++++++++++++++----------------
 net/sctp/sm_statetable.c                |   4 +-
 net/sctp/socket.c                       |   7 +-
 net/sctp/stream.c                       |   4 +-
 net/sctp/ulpevent.c                     |   2 +-
 net/sctp/ulpqueue.c                     |   2 +-
 27 files changed, 292 insertions(+), 283 deletions(-)
Signature · 1 line
2.1.0