Skip to content

Misc BPF helper/verifier improvements

Daniel Borkmann netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7bpf, net: add skb_mac_header_len helperinclude/linux/skbuff.h net/core/filter.c+7 -20 replies
2/7bpf: add bpf_skb_adjust_room helperinclude/uapi/linux/bpf.h net/core/filter.c tools/include/uapi/linux/bpf.h+151 -70 replies
3/7bpf: simplify narrower ctx accessinclude/linux/bpf.h include/linux/filter.h kernel/bpf/verifier.c +2 more+209 -1950 replies
4/7bpf: export whether tail call has jited ownerkernel/bpf/syscall.c+6 -10 replies
5/7bpf: extend bpf_trace_printk to support %ikernel/trace/bpf_trace.c+4 -30 replies
6/7bpf, verifier: add additional patterns to evaluate_reg_imm_alukernel/bpf/verifier.c+62 -00 replies
7/7bpf: add various test cases for verifier selftesttools/testing/selftests/bpf/test_verifier.c+165 -00 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchJohn FastabendAlexei StarovoitovDaniel Borkmann
1/7A-b A-b
2/7A-b A-b
3/7A-b
4/7A-b A-b
5/7A-b A-b
6/7A-b A-b
7/7A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH net-next 0/7] Misc BPF helper/verifier improvements

Miscellanous improvements I still had in my queue, it adds a new bpf_skb_adjust_room() helper for cls_bpf, exports to fdinfo whether tail call array owner is JITed, so iproute2 error reporting can be improved on that regard, a small cleanup and extension to trace printk, two verifier patches, one to make the code around narrower ctx access a bit more straight forward and one to allow for imm += x operations, that we've seen LLVM generating and the verifier currently rejecting. We've included the patch 6 given it's rather small and we ran into it from LLVM side, it would be great if it could be queued for stable as well after the merge window. Last but not least, test cases are added also related to imm alu improvement.

Thanks a lot!

Daniel Borkmann (5):
bpf, net: add skb_mac_header_len helper
bpf: add bpf_skb_adjust_room helper
bpf: simplify narrower ctx access
bpf: export whether tail call has jited owner
bpf: add various test cases for verifier selftest

John Fastabend (2):
bpf: extend bpf_trace_printk to support %i
bpf, verifier: add additional patterns to evaluate_reg_imm_alu

 include/linux/bpf.h                         |   9 +-
 include/linux/filter.h                      |  47 ++++
 include/linux/skbuff.h                      |   5 +
 include/uapi/linux/bpf.h                    |  16 +-
 kernel/bpf/syscall.c                        |   7 +-
 kernel/bpf/verifier.c                       | 140 +++++++----
 kernel/trace/bpf_trace.c                    |  38 ++-
 net/core/filter.c                           | 369 +++++++++++++++++-----------
 tools/include/uapi/linux/bpf.h              |  16 +-
 tools/testing/selftests/bpf/test_verifier.c | 165 +++++++++++++
 10 files changed, 604 insertions(+), 208 deletions(-)
Signature · 1 line
1.9.3