Skip to content

sctp: remove typedefs from structures part 2

Xin Long linux-sctp netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 1 replyIn review
  2. v111 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11sctp: remove the typedef sctp_ipv4addr_param_tinclude/linux/sctp.h net/sctp/protocol.c net/sctp/sm_make_chunk.c+5 -50 replies
2/11sctp: remove the typedef sctp_ipv6addr_param_tinclude/linux/sctp.h net/sctp/ipv6.c net/sctp/sm_make_chunk.c+4 -40 replies
3/11sctp: remove the typedef sctp_cookie_preserve_param_tinclude/linux/sctp.h net/sctp/sm_statefuns.c+8 -90 replies
4/11sctp: remove the typedef sctp_hostname_param_tinclude/linux/sctp.h+2 -20 replies
5/11sctp: remove the typedef sctp_supported_addrs_param_tinclude/linux/sctp.h net/sctp/sm_make_chunk.c+3 -30 replies
6/11sctp: remove struct sctp_ecn_capable_paraminclude/linux/sctp.h+0 -50 replies
7/11sctp: remove the typedef sctp_adaptation_ind_param_tinclude/linux/sctp.h net/sctp/sm_make_chunk.c+4 -40 replies
8/11sctp: remove the typedef sctp_supported_ext_param_tinclude/linux/sctp.h net/sctp/sm_make_chunk.c+10 -160 replies
9/11sctp: remove the typedef sctp_random_param_tinclude/linux/sctp.h include/net/sctp/structs.h net/sctp/auth.c+7 -80 replies
10/11sctp: remove the typedef sctp_chunks_param_tinclude/linux/sctp.h include/net/sctp/structs.h net/sctp/auth.c +1 more+7 -70 replies
11/11sctp: remove the typedef sctp_hmac_algo_param_tinclude/linux/sctp.h include/net/sctp/structs.h net/sctp/auth.c +1 more+7 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCHv2 net-next 00/11] sctp: remove typedefs from structures part 2

As we know, typedef is suggested not to use in kernel, even checkpatch.pl also gives warnings about it. Now sctp is using it for many structures.

All this kind of typedef's using should be removed. This patchset is the part 2 to remove it for another 11 basic structures.

Just as the part 1, No any code's logic would be changed in these patches, only cleaning up.

Note that v1->v2, nothing changed, just because net-next were closed when posting v1.

Xin Long (11):
sctp: remove the typedef sctp_ipv4addr_param_t
sctp: remove the typedef sctp_ipv6addr_param_t
sctp: remove the typedef sctp_cookie_preserve_param_t
sctp: remove the typedef sctp_hostname_param_t
sctp: remove the typedef sctp_supported_addrs_param_t
sctp: remove struct sctp_ecn_capable_param
sctp: remove the typedef sctp_adaptation_ind_param_t
sctp: remove the typedef sctp_supported_ext_param_t
sctp: remove the typedef sctp_random_param_t
sctp: remove the typedef sctp_chunks_param_t
sctp: remove the typedef sctp_hmac_algo_param_t

 include/linux/sctp.h       | 49 +++++++++++++++++++++-------------------------
 include/net/sctp/structs.h |  6 +++---
 net/sctp/auth.c            | 13 ++++++------
 net/sctp/endpointola.c     |  8 ++++----
 net/sctp/ipv6.c            |  2 +-
 net/sctp/protocol.c        |  2 +-
 net/sctp/sm_make_chunk.c   | 32 ++++++++++++------------------
 net/sctp/sm_statefuns.c    | 11 +++++------
 8 files changed, 55 insertions(+), 68 deletions(-)
Signature · 1 line
2.1.0