Skip to content

Support UDC on Tegra 20/30/114/124

Dmitry Osipenko linux-tegra 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest8 patches 5 repliesIn review
  2. v58 patches 2 repliesSuperseded
  3. v48 patches 1 replySuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v38 patches0 repliesSuperseded
v28 patches5 repliesSuperseded
v19 patches38 repliesSuperseded

Changes in v6 from the cover letter

1) Moved 'SKB reserve' quirk setup from f_ncm to u_uther as per Felipe's suggestion.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8usb: gadget: f_ncm/u_ether: Move 'SKB reserve' quirk setup to u_etherdrivers/usb/gadget/function/f_ncm.c drivers/usb/gadget/function/u_ether.c drivers/usb/gadget/function/u_ether.h+1 -40 replies
2/8usb: chipidea: udc: Support SKB alignment quirkdrivers/usb/chipidea/udc.c include/linux/usb/chipidea.h+4 -00 replies
3/8usb: chipidea: Add support for Tegra20/30/114/124drivers/usb/chipidea/Makefile drivers/usb/chipidea/ci_hdrc_tegra.c+156 -05 replies
4/8ARM: defconfig: tegra: Enable ChipIdea UDC driverarch/arm/configs/tegra_defconfig+5 -50 replies
5/8ARM: tegra: Enable UDC on Beaverarch/arm/boot/dts/tegra30-beaver.dts+10 -00 replies
6/8ARM: tegra: Enable UDC on Dalmorearch/arm/boot/dts/tegra114-dalmore.dts+10 -00 replies
7/8ARM: tegra: Enable UDC on Jetson TK1arch/arm/boot/dts/tegra124-jetson-tk1.dts+11 -10 replies
8/8ARM: tegra: Enable UDC on AC100arch/arm/boot/dts/tegra20-paz00.dts+2 -00 replies

Reviews trailers per patch

5 of 8 patches have a Reviewed-by or Acked-by.

PatchPeter ChenMichał MirosławStephen WarrenNicolas ChauvetMarc Dietrich
1/8
2/8A-b
3/8A-b T-b
4/8
5/8A-b
6/8
7/8A-b T-b
8/8A-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/8] Support UDC on Tegra 20/30/114/124

Some time ago Thierry Reding sent out patches that enabled UDC on NVIDIA Tegra, unfortunately they haven't got enough traction to get into the kernel. I've rebased those patches and added a fix for the Ethernet USB Gadget on Tegra20, Marc Dietrich tested UDC driver on AC100 (Tegra20), Nicolas Chauvet on TK1 (Tegra124) and Michał Mirosław on TF300T (Tegra30). Like an original patchset, this series adds support for the peripheral mode only.

Changelog:

V6:
1) Moved 'SKB reserve' quirk setup from f_ncm to u_uther as per Felipe's suggestion.

V5:
1) Moved of_device_get_match_data() above clock enabling to not leave clock enabled in case of error. The SoC data matching function shouldn't ever fail, but let's assume that it could for consistency.

V4:
1) Used of_device_get_match_data() instead of of_match_node() to cleanup code a tad.

V3:
1) Specified platform flags directly in the SoC info as per Michał's suggestion.

V2:
1) Added comments to each of patched USB Ethernet gadget models.

2) Added explanatory comment about why usb_phy_set_suspend() invocation is necessary in tegra_udc_probe().

3) Dropped TrimSlice from patchset because it turned out that it uses USB1 controller for USB-to-SATA.

4) Moved tegra_defconfig patch before DT patches as per Stephen's suggestion.

5) Changed dr_mode to "peripheral" in DT patches since we don't support role mode switching for now.

Dmitry Osipenko (4):
usb: gadget: f_ncm/u_ether: Move 'SKB reserve' quirk setup to u_ether
usb: chipidea: udc: Support SKB alignment quirk
ARM: defconfig: tegra: Enable ChipIdea UDC driver
ARM: tegra: Enable UDC on AC100

Thierry Reding (4):
usb: chipidea: Add support for Tegra20/30/114/124
ARM: tegra: Enable UDC on Beaver
ARM: tegra: Enable UDC on Dalmore
ARM: tegra: Enable UDC on Jetson TK1

 arch/arm/boot/dts/tegra114-dalmore.dts    |  10 ++
 arch/arm/boot/dts/tegra124-jetson-tk1.dts |  12 ++-
 arch/arm/boot/dts/tegra20-paz00.dts       |   2 +
 arch/arm/boot/dts/tegra30-beaver.dts      |  10 ++
 arch/arm/configs/tegra_defconfig          |  10 +-
 drivers/usb/chipidea/Makefile             |   1 +
 drivers/usb/chipidea/ci_hdrc_tegra.c      | 155 ++++++++++++++++++++++++++++++
 drivers/usb/chipidea/udc.c                |   3 +
 drivers/usb/gadget/function/f_ncm.c       |   2 -
 drivers/usb/gadget/function/u_ether.c     |   2 +-
 drivers/usb/gadget/function/u_ether.h     |   1 -
 include/linux/usb/chipidea.h              |   1 +
 12 files changed, 199 insertions(+), 10 deletions(-)
 create mode 100644 drivers/usb/chipidea/ci_hdrc_tegra.c
Signature · 1 line
2.13.3