Skip to content

#11552 - wic: avoid unnecessary dependencies

Ed Bartosh openembedded-core 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 0 repliesNew
  2. v18 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Fixed 2 more test cases
- Fixed default WKS_FILE_DEPENDS value (thanks to Patrick Ohly)
- Rebased on top of recent poky master

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8wic: get rid of using wic-toolsmeta/classes/image_types_wic.bbclass scripts/lib/wic/misc.py scripts/lib/wic/plugins/source/bootimg-pcbios.py +2 more+12 -140 replies
2/8wic: isoimage: do not remove temp directoryscripts/lib/wic/plugins/source/isoimage-isohybrid.py+2 -20 replies
3/8wic: build wic-tools only if wic is run manuallyscripts/wic+4 -40 replies
4/8wic: isoimage-isohybrid: check result of glob()scripts/lib/wic/plugins/source/isoimage-isohybrid.py+5 -20 replies
5/8wic-tools: don't create wic-tools.envmeta/recipes-core/meta/wic-tools.bb+1 -90 replies
6/8image_types_wic: set default WKS_FILE_DEPENDSmeta/classes/image_types_wic.bbclass+8 -10 replies
7/8wic: isoimage-isohybrid: use grub-efi from deploy dirscripts/lib/wic/plugins/source/isoimage-isohybrid.py+23 -520 replies
8/8selftest: fixed 5 wic test casesmeta/lib/oeqa/selftest/cases/wic.py+19 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/8] #11552 - wic: avoid unnecessary dependencies

Hi,

This patchset gets rid of building wic-tools for every image when IMAGE_FSTYPES contains 'wic'. Instead of using dependencies from wic-tools native sysroot wic expects image native sysroot to contain them. This should be done by setting WKS_FILE_DEPENDS variable in configuration files where WKS_FILE is set.

wic-tools can be used by wic when its run manually by pointing to the native sysroot using --native-sysroot option.

The patchset also contains fixes for the isoimage plugin and wic test suite breakages that were coused by the new changes.

Changes in v2:
- Fixed 2 more test cases
- Fixed default WKS_FILE_DEPENDS value (thanks to Patrick Ohly)
- Rebased on top of recent poky master

The following changes since commit f519ac010a7f7e018a83d85b6dc7778904b9a703:

oe-selftest: wic: fix test_quemu (2017-07-12 14:33:02 +0300)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ed/wic/wip
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/wic/wip

Ed Bartosh (8):
wic: get rid of using wic-tools
wic: isoimage: do not remove temp directory
wic: build wic-tools only if wic is run manually
wic: isoimage-isohybrid: check result of glob()
wic-tools: don't create wic-tools.env
image_types_wic: set default WKS_FILE_DEPENDS
wic: isoimage-isohybrid: use grub-efi from deploy dir
selftest: fixed 5 wic test cases

 meta/classes/image_types_wic.bbclass               | 11 ++-
 meta/lib/oeqa/selftest/cases/wic.py                | 23 +++++-
 meta/recipes-core/meta/wic-tools.bb                | 10 +--
 scripts/lib/wic/misc.py                            |  9 +--
 scripts/lib/wic/plugins/source/bootimg-pcbios.py   |  5 +-
 .../lib/wic/plugins/source/isoimage-isohybrid.py   | 88 ++++++++--------------
 scripts/wic                                        | 14 ++--
 7 files changed, 73 insertions(+), 87 deletions(-)

--
Regards,
Ed