Skip to content

staging: ccree: fix checkpatch errors

[email protected] linux-crypto 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5staging: ccree: remove redudant semicolonsdrivers/staging/ccree/ssi_buffer_mgr.c+1 -10 replies
2/5staging: ccree: fix placement of curly bracesdrivers/staging/ccree/ssi_buffer_mgr.c drivers/staging/ccree/ssi_cipher.c drivers/staging/ccree/ssi_driver.c +3 more+40 -740 replies
3/5staging: ccree: remove assignement in conditionaldrivers/staging/ccree/ssi_hash.c+4 -20 replies
4/5staging: ccree: export symbol immediately following functiondrivers/staging/ccree/ssi_fips.c+0 -20 replies
5/5staging: ccree: fix switch case indentationdrivers/staging/ccree/ssi_hash.c+12 -120 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGilad Ben-Yossef
SeriesA-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] staging: ccree: fix checkpatch errors

From: Tyler Olivieri <[email protected]>

This patchset fixes several checkpatch errors and warnings in /staging/ccree:

ERROR: that open brace { should be on the previous line
ERROR: open brace '{' following function declarations go on the next line
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
ERROR: do not use assignment in if condition
ERROR: switch and case should be at the same indent
WARNING: Statements terminations use 1 semicolon

This is also a submission for the eudyptula challenge.

Tyler Olivieri (5):
staging: ccree: remove redudant semicolons
staging: ccree: fix placement of curly braces
staging: ccree: remove assignement in conditional
staging: ccree: export symbol immediately following function
staging: ccree: fix switch case indentation

 drivers/staging/ccree/ssi_buffer_mgr.c | 14 ++----
 drivers/staging/ccree/ssi_cipher.c     |  6 ++-
 drivers/staging/ccree/ssi_driver.c     |  5 +-
 drivers/staging/ccree/ssi_fips.c       |  2 -
 drivers/staging/ccree/ssi_fips_ll.c    | 85 +++++++++++-----------------------
 drivers/staging/ccree/ssi_hash.c       | 33 +++++++------
 drivers/staging/ccree/ssi_sysfs.c      |  3 +-
 7 files changed, 57 insertions(+), 91 deletions(-)
Signature · 1 line
2.9.4