Skip to content

sctp: remove typedefs from structures part 3

Xin Long linux-sctp netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11sctp: remove the typedef sctp_initack_chunk_tinclude/linux/sctp.h net/sctp/sm_statefuns.c+10 -80 replies
2/11sctp: remove the typedef sctp_cookie_param_tinclude/linux/sctp.h net/sctp/sm_make_chunk.c+12 -100 replies
3/11sctp: remove the typedef sctp_unrecognized_param_tinclude/linux/sctp.h net/sctp/sm_statefuns.c+9 -130 replies
4/11sctp: remove the typedef sctp_gap_ack_block_tinclude/linux/sctp.h+4 -40 replies
5/11sctp: remove the typedef sctp_dup_tsn_tinclude/linux/sctp.h+1 -30 replies
6/11sctp: remove the typedef sctp_sack_variable_tinclude/linux/sctp.h net/sctp/outqueue.c+8 -80 replies
7/11sctp: remove the typedef sctp_sackhdr_tinclude/linux/sctp.h include/net/sctp/command.h net/sctp/sm_statefuns.c+6 -60 replies
8/11sctp: remove the typedef sctp_sack_chunk_tinclude/linux/sctp.h net/sctp/chunk.c net/sctp/sm_statefuns.c+5 -50 replies
9/11sctp: remove the typedef sctp_heartbeathdr_tinclude/linux/sctp.h net/sctp/sm_statefuns.c+4 -40 replies
10/11sctp: remove the typedef sctp_heartbeat_chunk_tinclude/linux/sctp.h net/sctp/sm_statefuns.c+4 -30 replies
11/11sctp: remove the typedef sctp_abort_chunk_tinclude/linux/sctp.h net/sctp/sm_statefuns.c+6 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 00/11] sctp: remove typedefs from structures part 3

As we know, typedef is suggested not to use in kernel, even checkpatch.pl also gives warnings about it. Now sctp is using it for many structures.

All this kind of typedef's using should be removed. This patchset is the part 3 to remove it for another 11 basic structures from linux/sctp.h.

Just as the part 1 and 2, No any code's logic would be changed in these patches, only cleaning up.

Xin Long (11):
sctp: remove the typedef sctp_initack_chunk_t
sctp: remove the typedef sctp_cookie_param_t
sctp: remove the typedef sctp_unrecognized_param_t
sctp: remove the typedef sctp_gap_ack_block_t
sctp: remove the typedef sctp_dup_tsn_t
sctp: remove the typedef sctp_sack_variable_t
sctp: remove the typedef sctp_sackhdr_t
sctp: remove the typedef sctp_sack_chunk_t
sctp: remove the typedef sctp_heartbeathdr_t
sctp: remove the typedef sctp_heartbeat_chunk_t
sctp: remove the typedef sctp_abort_chunk_t

 include/linux/sctp.h       | 53 +++++++++++++++++++++++-----------------------
 include/net/sctp/command.h |  4 ++--
 net/sctp/chunk.c           |  2 +-
 net/sctp/outqueue.c        | 10 ++++-----
 net/sctp/sm_make_chunk.c   | 18 +++++++++-------
 net/sctp/sm_statefuns.c    | 50 ++++++++++++++++++++-----------------------
 6 files changed, 68 insertions(+), 69 deletions(-)
Signature · 1 line
2.1.0