Skip to content

More warning reporting fixed

Alistair Francis qemu-devel 4 versions – Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest8 patches 5 repliesApplied
  2. v37 patches 8 repliesSuperseded
  3. v25 patches 20 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches9 repliesSuperseded

Changes in v4 from the cover letter

- Improve some extra MIPs messages
- Fix build issues
- Fix i386 print message

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/8hw/i386: Improve some of the warning messageshw/i386/acpi-build.c hw/i386/pc.c hw/i386/pc_q35.c+18 -121 reply
2/8Convert remaining error_report() to warn_report()block/qcow2.c target/s390x/kvm.c trace/control.c+9 -80 replies
3/8Convert single line fprintf(.../n) to warn_report()block/vvfat.c hw/acpi/core.c hw/i386/pc.c +9 more+21 -140 replies
4/8Convert multi-line fprintf() to warn_report()accel/kvm/kvm-all.c block/vvfat.c hw/acpi/core.c +12 more+63 -640 replies
5/8General warn report fixupsblock/vvfat.c hw/arm/vexpress.c hw/i386/xen/xen-mapcache.c +8 more+24 -270 replies
6/8target/mips: Convert VM clock update prints to warn_reporttarget/mips/kvm.c+3 -32 replies
7/8Makefile: Remove libqemustub.aMakefile Makefile.target docs/devel/build-system.txt +1 more+14 -170 replies
8/8Convert remaining single line fprintf() to warn_report()tests/Makefile.include util/cutils.c+3 -20 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchCornelia HuckMarkus ArmbrusterJames HoganPhilippe Mathieu-DaudéEduardo Habkost
1/8R-b
2/8A-b R-b
3/8R-b R-b
4/8A-b R-b
5/8R-b
6/8A-b R-b
7/8R-b
8/8R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH v4 0/8] More warning reporting fixed

This series expands on my previous series by converting more existing prints to use warn_report() instead of error_report() or fprintf().

As discussed with Paolo and Markus this series combines libqemustub.a into libqemuutil.a to avoid circular dependencies.

V4:
- Improve some extra MIPs messages
- Fix build issues
- Fix i386 print message
V3:
- Small corrections as reported by Markus
- Rename patch 3 and 5 so they don't have the same name
- Combine libqemustub.a into libqemuutil.a
- Add an extra patch with general cleanups

V2:
- Fixup auto CC logic so everyone is CCed

Alistair Francis (8):
hw/i386: Improve some of the warning messages Convert remaining error_report() to warn_report() Convert single line fprintf(.../n) to warn_report() Convert multi-line fprintf() to warn_report() General warn report fixups
target/mips: Convert VM clock update prints to warn_report
Makefile: Remove libqemustub.a
Convert remaining single line fprintf() to warn_report()

 Makefile                    |  7 +++----
 Makefile.target             |  2 +-
 accel/kvm/kvm-all.c         |  7 +++----
 block/qcow2.c               |  9 +++++----
 block/vvfat.c               |  7 ++++---
 docs/devel/build-system.txt | 16 +++++++---------
 hw/acpi/core.c              | 10 +++++-----
 hw/arm/vexpress.c           |  4 ++--
 hw/i386/acpi-build.c        | 15 ++++++++++-----
 hw/i386/pc.c                |  9 ++++-----
 hw/i386/pc_q35.c            |  8 +++++---
 hw/i386/xen/xen-mapcache.c  |  5 +++--
 hw/mips/mips_malta.c        |  4 ++--
 hw/mips/mips_r4k.c          |  5 ++---
 hw/misc/applesmc.c          |  2 +-
 hw/s390x/s390-virtio.c      | 18 ++++++++++--------
 hw/usb/hcd-ehci.c           |  5 +++--
 hw/virtio/virtio-balloon.c  |  3 ++-
 net/hub.c                   | 10 ++++------
 net/net.c                   | 15 ++++++++-------
 qga/vss-win32.c             |  2 +-
 target/i386/cpu.c           | 12 ++++++------
 target/i386/hax-mem.c       |  6 +++---
 target/mips/kvm.c           | 10 +++++-----
 target/ppc/translate_init.c | 17 ++++++++---------
 target/s390x/kvm.c          |  4 ++--
 tests/Makefile.include      |  8 ++++----
 trace/control.c             |  4 ++--
 trace/simple.c              |  3 ++-
 ui/keymaps.c                | 10 +++++-----
 ui/spice-display.c          |  2 +-
 util/cutils.c               |  3 ++-
 util/main-loop.c            |  6 +++---
 33 files changed, 128 insertions(+), 120 deletions(-)
Signature · 1 line
2.11.0