Skip to content

zfcp fixes and cleanups

Benjamin Block linux-s390 linux-scsi stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22zfcp: replace zfcp_qdio_sbale_count by sg_nentsdrivers/s390/scsi/zfcp_fsf.c drivers/s390/scsi/zfcp_qdio.h+1 -170 replies
2/22zfcp: use setup_timer instead of init_timerdrivers/s390/scsi/zfcp_erp.c+2 -30 replies
3/22zfcp: Remove unneeded linux/miscdevice.h includedrivers/s390/scsi/zfcp_aux.c+0 -10 replies
4/22zfcp: convert bool-definitions to use 'true' instead of '1'drivers/s390/scsi/zfcp_qdio.c drivers/s390/scsi/zfcp_scsi.c+2 -20 replies
5/22zfcp: fix queuecommand for scsi_eh commands when DIX enableddrivers/s390/scsi/zfcp_fsf.c+2 -10 replies
6/22zfcp: add handling for FCP_RESID_OVER to the fcp ingress pathdrivers/s390/scsi/zfcp_fc.h+5 -10 replies
7/22zfcp: fix capping of unsuccessful GPN_FT SAN response trace recordsdrivers/s390/scsi/zfcp_dbf.c drivers/s390/scsi/zfcp_fsf.c+11 -30 replies
8/22zfcp: fix passing fsf_req to SCSI trace on TMF to correlate with HBAdrivers/s390/scsi/zfcp_dbf.h drivers/s390/scsi/zfcp_scsi.c+8 -70 replies
9/22zfcp: fix missing trace records for early returns in TMF eh handlersdrivers/s390/scsi/zfcp_scsi.c+6 -20 replies
10/22zfcp: fix payload with full FCP_RSP IU in SCSI trace recordsdrivers/s390/scsi/zfcp_dbf.c+17 -40 replies
11/22zfcp: trace HBA FSF response by default on dismiss or timedout late responsedrivers/s390/scsi/zfcp_dbf.h+5 -10 replies
12/22zfcp: trace high part of "new" 64 bit SCSI LUNdrivers/s390/scsi/zfcp_dbf.c drivers/s390/scsi/zfcp_dbf.h+4 -20 replies
13/22zfcp: more fitting constant for fc_ct_hdr.ct_reason on port scan responsedrivers/s390/scsi/zfcp_fc.c+2 -20 replies
14/22zfcp: clarify that we don't need "link" test on failed open portdrivers/s390/scsi/zfcp_fsf.c+3 -10 replies
15/22zfcp: use common code fcp_cmnd and fcp_resp with union in fsf_qtcb_bottom_iodrivers/s390/scsi/zfcp_dbf.c drivers/s390/scsi/zfcp_dbf.h drivers/s390/scsi/zfcp_fsf.c +1 more+17 -100 replies
16/22zfcp: use endianness conversions with common FC(P) struct fieldsdrivers/s390/scsi/zfcp_dbf.c drivers/s390/scsi/zfcp_fc.c drivers/s390/scsi/zfcp_fc.h +1 more+43 -350 replies
17/22zfcp: fix kernel doc comment typos for struct zfcp_dbf_scsidrivers/s390/scsi/zfcp_dbf.h+3 -30 replies
18/22zfcp: clean up redundant code with fall through in link down SRB switch casedrivers/s390/scsi/zfcp_fsf.c+0 -20 replies
19/22zfcp: clean up no longer existent prototype from zfcp API headerdrivers/s390/scsi/zfcp_ext.h+0 -10 replies
20/22zfcp: clean up a member of struct zfcp_qdio that was assigned but never useddrivers/s390/scsi/zfcp_fsf.c drivers/s390/scsi/zfcp_qdio.h+0 -30 replies
21/22zfcp: clean up unnecessary module_param_named() with no_auto_port_rescandrivers/s390/scsi/zfcp_fc.c+1 -10 replies
22/22zfcp: early returns for traces disabled via leveldrivers/s390/scsi/zfcp_dbf.c+46 -80 replies

Reviews trailers per patch

18 of 22 patches have a Reviewed-by or Acked-by.

PatchBenjamin BlockSteffen MaierJens Remus
1/22
2/22
3/22
4/22
5/22R-b
6/22R-b
7/22R-b
8/22R-b
9/22R-b
10/22R-b
11/22R-b
12/22R-b R-b
13/22R-b
14/22R-b
15/22R-b
16/22R-b
17/22R-b
18/22R-b
19/22R-b
20/22R-b
21/22R-b
22/22R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/22] zfcp fixes and cleanups

Hi all,

here is a series of (important) fixes and some additional cleanups for the zfcp driver. Our fixes are marked for stable accordingly.

Patches 01 - 04 are cleanups and external patches (also cleanups) that we
& 13 - 22 had queued for quite some time now

Patches 05 - 12 are driver fixes that are all marked for stable as well

The set applies to the fixes branch of James' scsi.git.

Beste Grüße / Best regards,
- Benjamin Block

Benjamin Block (2):
zfcp: convert bool-definitions to use 'true' instead of '1'
zfcp: add handling for FCP_RESID_OVER to the fcp ingress path

Corentin Labbe (1):
zfcp: Remove unneeded linux/miscdevice.h include

LABBE Corentin (1):
zfcp: replace zfcp_qdio_sbale_count by sg_nents

Lukáš Korenčik (1):
zfcp: use setup_timer instead of init_timer

Martin Peschke (4):
zfcp: clean up redundant code with fall through in link down SRB
switch case
zfcp: clean up a member of struct zfcp_qdio that was assigned but
never used
zfcp: clean up unnecessary module_param_named() with
no_auto_port_rescan
zfcp: early returns for traces disabled via level

Steffen Maier (13):
zfcp: fix queuecommand for scsi_eh commands when DIX enabled
zfcp: fix capping of unsuccessful GPN_FT SAN response trace records
zfcp: fix passing fsf_req to SCSI trace on TMF to correlate with HBA
zfcp: fix missing trace records for early returns in TMF eh handlers
zfcp: fix payload with full FCP_RSP IU in SCSI trace records
zfcp: trace HBA FSF response by default on dismiss or timedout late
response
zfcp: trace high part of "new" 64 bit SCSI LUN
zfcp: more fitting constant for fc_ct_hdr.ct_reason on port scan
response
zfcp: clarify that we don't need "link" test on failed open port
zfcp: use common code fcp_cmnd and fcp_resp with union in
fsf_qtcb_bottom_io
zfcp: use endianness conversions with common FC(P) struct fields
zfcp: fix kernel doc comment typos for struct zfcp_dbf_scsi
zfcp: clean up no longer existent prototype from zfcp API header

 drivers/s390/scsi/zfcp_aux.c  |  1 -
 drivers/s390/scsi/zfcp_dbf.c  | 95 +++++++++++++++++++++++++++++++++++--------
 drivers/s390/scsi/zfcp_dbf.h  | 25 ++++++++----
 drivers/s390/scsi/zfcp_erp.c  |  5 +--
 drivers/s390/scsi/zfcp_ext.h  |  1 -
 drivers/s390/scsi/zfcp_fc.c   | 52 +++++++++++------------
 drivers/s390/scsi/zfcp_fc.h   | 25 ++++++++----
 drivers/s390/scsi/zfcp_fsf.c  | 35 ++++++++--------
 drivers/s390/scsi/zfcp_fsf.h  | 12 ++++--
 drivers/s390/scsi/zfcp_qdio.c |  2 +-
 drivers/s390/scsi/zfcp_qdio.h | 17 --------
 drivers/s390/scsi/zfcp_scsi.c | 18 ++++----
 12 files changed, 178 insertions(+), 110 deletions(-)

--
2.11.2